Skip to content

fix: libraft-headers-only declares unused C compiler - #3116

Open
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:codequality/recipe-libraft-headers-only-declares-unused-c
Open

fix: libraft-headers-only declares unused C compiler#3116
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:codequality/recipe-libraft-headers-only-declares-unused-c

Conversation

@andrewwhitecdw

Copy link
Copy Markdown

This PR addresses the following issue in conda/recipes/libraft/recipe.yaml: libraft-headers-only declares unused C compiler.

Changes

  • conda/recipes/libraft/recipe.yaml: libraft-headers-only declares unused C compiler.

Details

--- a/conda/recipes/libraft/recipe.yaml
+++ b/conda/recipes/libraft/recipe.yaml
@@ -1,19 +1,18 @@
-  - package:
-      name: libraft-headers-only
-      version: ${{ version }}
-    build:
-      script:
-        content: |
-          # Unspecified brings in all components
-          cmake --install cpp/build --component Unspecified
-          cmake --install cpp/build --component raft
-          cmake --install cpp/build --component distributed
-      string: cuda${{ cuda_major }}_${{ datetime_string }}_${{ head_rev }}
-      dynamic_linking:
-        overlinking_behavior: "error"
-    requirements:
-      build:
-        - cmake ${{ cmake_version }}
-        - ${{ compiler("c") }}
-      host:
-        - cuda-version =${{ cuda_version }}
+  - package:
+      name: libraft-headers-only
+      version: ${{ version }}
+    build:
+      script:
+        content: |
+          # Unspecified brings in all components
+          cmake --install cpp/build --component Unspecified
+          cmake --install cpp/build --component raft
+          cmake --install cpp/build --component distributed
+      string: cuda${{ cuda_major }}_${{ datetime_string }}_${{ head_rev }}
+      dynamic_linking:
+        overlinking_behavior: "error"
+    requirements:
+      build:
+        - cmake ${{ cmake_version }}
+      host:
+        - cuda-version =${{ cuda_version }}

Tests

Let me know if you want tests added for this fix or not.

Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>
@andrewwhitecdw
andrewwhitecdw requested a review from a team as a code owner August 13, 2026 01:34
@copy-pr-bot

copy-pr-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b5252a24-cbdb-4463-8d1e-95364b02a296

📥 Commits

Reviewing files that changed from the base of the PR and between e2437c4 and c5cf2ce.

📒 Files selected for processing (1)
  • conda/recipes/libraft/recipe.yaml
💤 Files with no reviewable changes (1)
  • conda/recipes/libraft/recipe.yaml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Simplified the headers-only package build requirements by removing an unnecessary compiler dependency.

Walkthrough

The libraft-headers-only output removes the C compiler from its build requirements. The versioned CMake dependency remains.

Changes

libraft packaging

Layer / File(s) Summary
Headers-only build requirements
conda/recipes/libraft/recipe.yaml
The libraft-headers-only output keeps only the versioned CMake build requirement.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Mergeability Score: ⚪ Minimal · up to c5cf2

This localized recipe cleanup removes an unused C compiler dependency and introduces no actionable merge-blocking risk; it is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes removal of the unused C compiler requirement from libraft-headers-only.
Description check ✅ Passed The description directly explains the removed build requirement and includes the relevant file and diff.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant