Draft
Conversation
shijieliu
reviewed
Mar 18, 2026
| disable_kvcache=args.disable_kvcache, | ||
| max_bs=args.max_bs, | ||
| ) | ||
| elif args.mode == RunningMode.SNAP: |
Collaborator
There was a problem hiding this comment.
Adding a new mode for export is strange to me. Can we replace the inference code path w/o kvcache with this new exportable implementation?
| ~$ python3 ./inference/inference_gr_ranking.py --gin_config_file ./inference/configs/kuairand_1k_inference_ranking.gin --checkpoint_dir ${PATH_TO_CHECKPOINT} --mode eval | ||
| ``` | ||
|
|
||
| ## Example: Kuairand-1K for Snap |
Collaborator
There was a problem hiding this comment.
it's better for us not to name it as Snap
jensenhwa
force-pushed
the
jhwa/snap_export
branch
from
919206d to
58c9131
Compare
shijieliu
reviewed
Mar 31, 2026
| ebc_config.dim == self._embedding_dim | ||
| ), "hstu layer hidden size should equal to embedding dim" | ||
|
|
||
| self._hstu_block = HSTUBlockInference(hstu_config, kvcache_config) |
Collaborator
There was a problem hiding this comment.
choose between HSTUBlockInference or HSTUBlock by configuration @geoffreyQiu
shijieliu
reviewed
Mar 31, 2026
| @@ -0,0 +1,103 @@ | |||
| ARG BASE_IMAGE=nvcr.io/nvidia/pytorch:26.02-py3 | |||
Collaborator
There was a problem hiding this comment.
@geoffreyQiu try merge this dockerfile with existing dockerfile. if needed, we can update torchrec to 1.4.0 or 1.5.0. but torchrec 1.5.0 needs compatibility change in dynamicemb
shijieliu
reviewed
Mar 31, 2026
Collaborator
There was a problem hiding this comment.
merge this into fbgemm dev after verified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.