Skip to content

Drop stale skill counts from Repository Structure#43

Merged
sayalinvidia merged 1 commit into
NVIDIA:mainfrom
sayalinvidia:drop-stale-skill-counts
May 1, 2026
Merged

Drop stale skill counts from Repository Structure#43
sayalinvidia merged 1 commit into
NVIDIA:mainfrom
sayalinvidia:drop-stale-skill-counts

Conversation

@sayalinvidia
Copy link
Copy Markdown
Collaborator

Hardcoded counts in this block were drifting from reality (e.g. TensorRT-LLM listed as 20 vs actual 24, Megatron-Bridge 9 vs 25). The Available Skills table is the canonical source for counts; keeping them in two places was a maintenance trap.

Reviewer follow-up from #40.

Onboarding type

  • New product onboarding (new components.d/<slug>.yml file)
  • Other (catalog change, README fix, infrastructure, etc.)

For new product onboarding — author affirmations

By submitting this PR, I confirm on behalf of my team:

  • Skills cleared for open source release per NVIDIA's internal IP review process (six-question check, all answers affirmative)
  • License selected: Apache 2.0 / CC-BY 4.0 / Dual (Apache 2.0 + CC-BY 4.0). Specify: _____
  • No new license or new third-party component introduced beyond what the source repo already carries
  • Source repo is public and under an NVIDIA-owned GitHub org
  • .agents/skills/ or skills/ path used for new entries (or existing path retained for legacy entries per components.d/<slug>.yml)

NVIDIA contributors: see the internal onboarding guide for the IP review process details and license selection.

Reviewer checklist (OSS Skills PIC)

  • Author confirmations above are checked
  • components.d/<slug>.yml entry valid (required fields, unique catalog_dir, path exists in source repo, filename slug matches name)
  • SKILL.md frontmatter spec-compliant (at least one sampled)
  • No new license or third-party dependency requiring OSRB filing

All PRs

  • All commits signed off with DCO (git commit -s).
    If you forgot, run git rebase --signoff origin/main && git push --force-with-lease to retroactively sign all commits in your branch.

Other context (for non-onboarding PRs)

Hardcoded counts in this block were drifting from reality (e.g.
TensorRT-LLM listed as 20 vs actual 24, Megatron-Bridge 9 vs 25).
The Available Skills table is the canonical source for counts;
keeping them in two places was a maintenance trap.

Reviewer follow-up from NVIDIA#40.

Signed-off-by: Sayali Kandarkar <skandarkar@nvidia.com>
@sayalinvidia sayalinvidia marked this pull request as ready for review May 1, 2026 19:08
@sayalinvidia sayalinvidia requested a review from mosheabr as a code owner May 1, 2026 19:08
@sayalinvidia sayalinvidia merged commit 60ddff7 into NVIDIA:main May 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant