Skip to content

docs: correct the ReflectoExp README against the code - #10

Merged
NaNIsaac merged 1 commit into
mainfrom
docs/lineage-audit
Oct 23, 2026
Merged

NaNIsaac merged 1 commit into
mainfrom
docs/lineage-audit

Conversation

@NaNIsaac

Copy link
Copy Markdown
Owner

Tier: low (README only)

Evidence

  • Isaac's directive (2026-10-23, §3): the four XRR repositories are research branches with different models and fitting methods; later is not assumed better. The removed line came from d964243 (2026-10-16), an agent README pass, and called this repository a closed record although exp07 was still developed here in August 2026 (1c2ae53, ec2f34a: ablation on two domains).
  • Code moves (compared file by file): Reflecto engines/model.py = exp07 xrr_model.py at b93c91f, Reflecto assets/config.json = exp07 config values at b93c91f; XRefine's first commit 9e3834e (2025-12-30 19:26) contains src/reflecto_exp/simulate/torch_engine/ from abd6660 (same day 12:11) with at most 6 differing lines per file; ReflectoLearn f35ab56 (2026-06-01) model.py and train.py derive from exp07. No comparison between these and the results here exists.
  • exp07 outputs: runs/exp07_fourier_hires/main.py:160 output_dim=3, # [Thick, Rough, SLD]; the SiO2 parameters are randomized in the simulation (config.py sio2_* ranges) and not predicted.
  • exp01 imports reflecto_exp.simulate.simul_refnx (runs/exp01_quan_class/dataset.py:17), so it needs refnx too.
  • exp03: train_fused.py:16 imports fused_loss_with_confidence; model_fused.py:107 defines only fused_loss_with_masking.
  • base_dir: exp02 and exp06 use $DATA; exp04, exp05, exp07 have drive paths (runs/*/config.py).
  • torch_engine is imported by no file under runs/ (grep).

Tests: none affected (README only). Part of the lineage audit (BACKLOG A1).

@NaNIsaac
NaNIsaac merged commit 0f222f9 into main Oct 23, 2026
1 check passed
@NaNIsaac
NaNIsaac deleted the docs/lineage-audit branch October 23, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant