vk renderer update#10
Open
wsqjny wants to merge 1 commit intoNadrin:masterfrom
Open
Conversation
…> VK_LAYER_KHRONOS_validation 2. fix bug: update all mips of "envTextureUnfiltered" image layout before cs dispatch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi~ I'm new to vulkan. very happy to see your pbr demo source, it helps me a lot.
However, I found in the new version of vulkan (1.2.154.1), the following two places seem to need to be changed:
Validation Layers changed : VK_LAYER_LUNARG_standard_validation -> VK_LAYER_KHRONOS_validation.
https://vulkan.lunarg.com/doc/view/1.1.114.0/windows/validation_layers.html
There are some image layout warnings when running, like ".....(subresource: aspectMask 0x1 array layer 0, mip level 1) to be in layout VK_IMAGE_LAYOUT_GENERAL--instead, current layout is VK_IMAGE_LAYOUT_UNDEFINED."
It seems that all the mips of the "envTextureUnfiltered" image shouled be changed before cs dispatch.
Thank you~