Reusable code for component efficiencies#279
Open
kylecarow wants to merge 41 commits into
Open
Conversation
Updated Anaconda setup instructions to specify environment name and include pip upgrade.
…t drive cycle section
… started to use plotly and new demo conventions, small tweak to test demos to render plots as JSON (replacement for SHOW_PLOTS)
updated getting started demo with mines demo content, updated getting…
…st using pytest --nbmake (which is set to run by default in pyproject.toml with parallelization - you may need to reinstall dev dependencies before use)
# Conflicts: # pixi.lock
# Conflicts: # pixi.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #287
Merge first, or rebase this branch:
Creates reusable code to implement on types like
RESEfficiencythat check range of data, interpolated point result, and delegate to underlying interpolator appropriately. Avoids a lot of repeated boilerplate for efficiency enums.Renames EffInterp, so this has implications for downstream Rust projects. Since we are bumping to 3.1.0 soon, I dont have a problem with this - we should suggest downstream project Rust users pin to a minor version:
in this way we can keep the major version 3 and leave breaking changes to increments of minor versions, rather than making a million major versions.
Whereas before this would have a lot of matching code to call underlying interpolators:
It now only needs this to implement interpolator methods, which have extra validation code and delegate to the contained interpolator. All other min/max/etc methods are implemented by this automatically too.
This will make it easier to make e.g.
FCEfficiency,EMEfficiencytypes.