Update QueueWorker.php interface to match actual features#107
Merged
Conversation
skeemer
added a commit
to skeemer/nativephp.com
that referenced
this pull request
Apr 8, 2026
Fixes NativePHP/desktop#107 While in here, I double checked the `new QueueConfig()` instruction and realized that it couldn't work because `sleep` does not have a default for instantiation, only in `fromConfigArray()`.
Contributor
Author
|
Can you reopen? I accidentally referenced this number instead of #106 |
simonhamp
approved these changes
May 21, 2026
simonhamp
requested changes
May 21, 2026
simonhamp
left a comment
simonhamp
left a comment
Member
There was a problem hiding this comment.
Looks like this is causing a whole bunch of test failures
Contributor
Author
|
Got them running fine locally with 8.3 and --prefer-lowest. |
Contributor
Author
|
The linter seems to be set up wrong for 3rd party PRs. |
Member
|
Yeh we can ignore that one for now, it's been problematic for a while. Thanks for fixing the fake so the tests pass 🙏🏼 |
simonhamp
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #106