Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tapping the already-selected Log tab in the bottom bar now takes the current log back to the top and fetches the newest commits. Commits already waiting in the new-commits pill go in immediately; Trending re-ranks like pull-to-refresh.
What changed
Tab::onReselect()to NativePHP's bottom-tab API and wires theon_reselectcallback in both native renderers.UITabBartap observer because SwiftUI'sTabViewdoes not report a tap on the already-selected tab. The observer only watches; it leaves the bar and its delegate alone.Log::backToTopAndFetchNewest()resets the list key, applies the pill on Following/Latest, and calls the existingload()refresh.The NativePHP patch
on_reselectis not in a released NativePHP version yet, so the app carries a version-pinned patch fornativephp/mobile4.7.x:patches/nativephp-mobile-tab-reselect.patch(PHP side, applied in the staged on-device copy too)patches/nativephp-mobile-tab-reselect-native.patch(iOS/Android renderers)scripts/apply-nativephp-patches.php, wired into Composer'spost-install-cmdandpost-update-cmdThe script fails loudly on a NativePHP version bump, and warns when
native:install --forcehas not copied the patched renderers intonativephp/ios/nativephp/android. The long-term fix is an upstream PR toNativePHP/mobile-air; once released, the patch and hook can be deleted.Tests
php artisan test --compact— 1708 passed, 2 deprecated, 1 skipped.vendor/bin/pint --dirty --format agent— passed.Android was not built because no emulator was running; the Compose path is patched but still needs a device check. The iOS tap was also not confirmed after the final observer fix, so this is a draft until the manual check passes.
Screenshots
Behavior-only change: no screen looks different. Once the iOS tap is confirmed, a short recording of the gesture can be added if reviewers want it.