Repository navigation
feat: translate commits in the native app - #167
Draft
ricardovfreixo wants to merge 3 commits into
Draft
ricardovfreixo wants to merge 3 commits into
ricardovfreixo wants to merge 3 commits into
Conversation
Contributor
Author
|
Fixed the CI integration failure in 605db16. The pull-request merge included the newer swipe-to-reply implementation from main, but its locked NativePHP packages lacked the required gesture trigger props and test API. Merged current main and pinned the matching core/UI upstream revisions; no tests were weakened or skipped. GitHub Tests now pass: 1,871 passed, 37 skipped, 17,388 assertions. These pins include native code and will require a rebuild before renewed device verification. The installed phone build was not changed during this fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bring the web's commit translation experience to native mobile screens: automatically display shared cached translations when enabled, generate a missing translation only after tapping Translate, and switch back with Show original.
Closes #166.
Dependency: backend API support in dev-null-sh/dev-null.sh#1494 must be merged and deployed. This PR is a draft pending end-to-end verification of translated posts against that deployment.
Changes
mainand pin the two NativePHP SDK revisions required by its swipe-to-reply feature: core10c21b24(Let a gesture area's pan trigger when let go far enough mobile-air#651) and UI55f7c42c(Let a gesture area's pan trigger when let go far enough, on iOS and Android mobile-ui#197). Only these two dependency package records changed; no tests were removed or skipped to fix CI.Validation
605db16ef30c9545045ae220e272ad4159436ea4: 1,871 passed, 37 skipped, 17,388 assertions. Successful run.PHP_INI_SCAN_DIR=/tmp/devnull-local/php COMPOSER=composer.free.json php artisan test --compact -d memory_limit=1G— 1,869 passed, 37 skipped, 2 deprecated; 17,388 assertions; exit 0 after merging currentmainand updating the SDK pins.composer validate --strictexits nonzero solely for its expected warnings about the approved explicit commit references.vendor/bin/pint --dirty --format agentandgit diff --check— passed.68c388f86276133b52585112a187a899e0cb7f8c; committed head2b3505335656d759e8b908ae79d0b238d664db81has the same reviewed content. Reviewer inspected source, tests, and supplied validation artifacts; did not independently rerun the suite or operate the device.Limitations
Screenshots
Android-only evidence, light and dark mode. The language sheet is new, so it has after-only captures. Recordings show real picker/search/save and preference restoration/toggling; encoded durations are approximately 8.6 seconds (light) and 12.9 seconds (dark).
Log — compatibility with the current backend
Account settings
New language picker and search
Recordings: Android light · Android dark