Repository navigation
Require a demo video before plugins can be submitted for review - #534
Merged
Merged
Conversation
simonhamp
approved these changes
Sep 25, 2026
simonhamp
left a comment
Member
There was a problem hiding this comment.
Looks great! Thanks @sonalidudhia
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require a demo video before a plugin can be submitted for review
Why
Reviewers currently have no quick way to see that a submitted plugin actually works. This adds a required demo video: developers link a short YouTube, Vimeo or Loom video of the plugin running on a real device or simulator, and admins can watch it inside Filament before approving.
What changes
Developer dashboard (plugin → Details tab, drafts only)
youtu.be/ Shorts), Vimeo (incl. unlisted/{id}/{hash}) or LoomsubmitForReview()refuses to submit without an attested video.Enforcement
Plugin::passesRequiredReviewChecks()/getFailingRequiredChecks()now include the demo video, so the Filament Approve button stays disabled without one.PluginReviewChecksIncompleteemail lists the demo video as passing/missing.Admin (Filament → Plugins → Edit)
Public plugin page
Implementation notes
demo_video_url,demo_video_attested_at,show_demo_videotoplugins.App\Support\DemoVideoparses provider URLs and builds embed/oEmbed URLs.App\Rules\DemoVideoUrldoes the host + oEmbed check (10s timeout, logs connection failures).youtube-nocookie.comfor YouTube.relativebecause of the global.aspect-video iframe { position: absolute }rule.PluginFactorynow includes an attested video by default and addswithoutDemoVideo()/withPublicDemoVideo()states, so existing tests keep their meaning.Plugins that are already pending review have no video, so they cannot be approved until the developer adds one. It may be worth emailing current pending developers (the "Email Developer" action already lists the new check), or approving the current queue before deploying.