Skip to content

Fix browser input and action dispatch on current NativePHP - #4

Merged
shanerbaner82 merged 1 commit into
mainfrom
fix/ui-event-dispatch
Oct 4, 2026
Merged

shanerbaner82 merged 1 commit into
mainfrom
fix/ui-event-dispatch

Conversation

@shanerbaner82

Copy link
Copy Markdown
Contributor

Typing into a browser login field crashed because the web runner passed an event array to NativeComponent::dispatch(), which now accepts a named component event.

Route browser input and action events through dispatchUiEvent() when available. Retain the legacy dispatch() call for older NativePHP versions, preserving the existing package compatibility range. No wire format or snapshot changes.

Validation:

  • Reproduced the exact TypeError with a Curbshot HTTP regression test before the fix.
  • The regression now passes: email/password updates retain state and a submit event authenticates a valid user.
  • All 48 focused consuming-app tests pass on NativePHP Mobile 4.5.2.
  • Chrome verified typing and submission; invalid credentials show normal validation feedback without a crash.
  • Pint passes. The HTTP regression lives in the consuming Curbshot checkout; this plugin repository runs Pint in CI.

@shanerbaner82
shanerbaner82 merged commit cfc2b13 into main Oct 4, 2026
1 check passed
@shanerbaner82
shanerbaner82 deleted the fix/ui-event-dispatch branch October 4, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant