fix: include tvOS in simulator discovery - #135
Merged
NathanWalker merged 1 commit intoSep 12, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 8, 2026
LorenzGit
marked this pull request as ready for review
September 8, 2026 18:44
NathanWalker
added a commit
to LorenzGit/nativescript-cli
that referenced
this pull request
Sep 12, 2026
- Plugins keep their native code for visionOS and tvOS in platforms/ios. Change detection and native-file watching now resolve that folder the same way preparation already did (IMobileHelper.getPluginPlatformsFolderName), so an edit to a plugin's iOS sources is seen by tvOS/visionOS builds and watch mode. - getEmulatorImages only queried iOS simulators for the iOS platform, so startEmulator could not find a simulator for tvOS or visionOS. - ios-sim-portable 4.5.4 for tvOS simulator discovery (NativeScript/ios-sim-portable#135); also brings package-lock back in sync with package.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include Apple TV simulator runtimes in simulator discovery while retaining iOS and visionOS handling.
Validation
The local package is installed into the reviewer CLI. Release app installation/launch and debug ns test tvos succeed using the selected Apple TV simulator. Independent of runtime publishing.
Reproduce
Revision-pinned reviewer setup builds the companion stack in an isolated workspace. It includes commands, requirements, dependency pins and physical-device limitations. No binary artifacts or private development paths are committed.
This PR contains one commit,
5543c967a620450766136597d8b14bab371f1efc, changing 1 files againstd4b7ed5920361fafe08b81a4070893e8e82879e7. Its exported patch reproduces the committed tree from a fresh base index.The source-built runtime was validated in the prepared runtime checkout; companion clones, native helpers, Canvas and clean npm installation were validated in a separate workspace on the same Mac. A second machine and one uninterrupted cold
allrun have not been tested.