feat: HMR dev-sessions, ESM resolver hardening, dev-mode runtime globals#383
Draft
NathanWalker wants to merge 1 commit into
Draft
feat: HMR dev-sessions, ESM resolver hardening, dev-mode runtime globals#383NathanWalker wants to merge 1 commit into
NathanWalker wants to merge 1 commit into
Conversation
Adds the Hot Module Replacement runtime layer plus the supporting ESM resolver hardening and dev-session globals that make hot reload viable on iOS.
* `import.meta.hot`: `data`, `accept`, `dispose`, `prune`,
`decline`, `invalidate`, `on`/`off`/`send` event surface.
* Dev-session globals (`__nsStartDevSession`, `__nsReloadDevApp`,
`__nsInvalidateModules`, `__nsRunHmrDispose`, `__nsRunHmrPrune`,
`__nsKickstartHmrPrefetch`, `__nsGetLoadedModuleUrls`,
`__nsApplyStyleUpdate`, `__nsConfigureDevRuntime`,
`__nsTerminateAllWorkers`).
* Speculative HTTP module prefetch with canonical-key normalization so
`__ns_hmr__/v<N>` and `__ns_boot__/b<N>` tag prefixes share `hot.data`
identity across reload cycles.
* ESM resolver hardening in `ModuleInternalCallbacks.mm` to:
- Preserve synthetic-namespace identity (`ns-vendor://`,
`optional:`, `node:`, `blob:`) — these are NOT filesystem paths.
- Handle HTTP/HTTPS module URLs end-to-end (resolution, fetch,
canonical-key collapse, dynamic import).
- Compile `.json` imports into synthetic ES modules.
* `NodeBuiltinsAndOptionalModulesTests.mjs`, `HttpEsmLoaderTests.js`,
`hot-data-ext.{js,mjs}` test fixtures, plus integration wiring in
`TestRunnerTests.swift` and the Jasmine boot harness.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds robust Hot Module Replacement plus the supporting ESM resolver hardening and dev-session globals that make hot reload viable on iOS.
import.meta.hot:data,accept,dispose,prune,decline,invalidate,on/off/sendevent surface.__nsStartDevSession,__nsReloadDevApp,__nsInvalidateModules,__nsRunHmrDispose,__nsRunHmrPrune,__nsKickstartHmrPrefetch,__nsGetLoadedModuleUrls,__nsApplyStyleUpdate,__nsConfigureDevRuntime,__nsTerminateAllWorkers).__ns_hmr__/v<N>and__ns_boot__/b<N>tag prefixes sharehot.dataidentity across reload cycles.ModuleInternalCallbacks.mmto:.jsonimports into synthetic ES modules.