Repository navigation
feat: CommonLogger accepts a message with data - #168
Merged
Merged
Conversation
fiddur
changed the title
fiddur
force-pushed
the
feat/common-logger-msg-data
branch
from
October 8, 2026 09:19
0c944f0 to
d5fe91d
Compare
`logger.warn('failed', { err })` next to the single-argument form; the data fields are merged
under the message.
Claude-Session: https://claude.ai/code/session_01JuGyKbJyWXdXBeNS7VdnU1
fiddur
force-pushed
the
feat/common-logger-msg-data
branch
from
October 8, 2026 09:22
d5fe91d to
2be9e5a
Compare
fiddur
changed the title
fiddur
marked this pull request as ready for review
October 8, 2026 09:23
mrnagydavid
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #167. Each
CommonLoggermethod now accepts two forms: