Adding channelled melee attacks.#5372
Draft
MistakeNot4892 wants to merge 1 commit into
Draft
Conversation
MistakeNot4892
added
the
work in progress
MistakeNot4892
force-pushed
the
feature/melee
branch
5 times, most recently
from
7b7ea76 to
6fa0bc1
Compare
Contributor
Author
Also now depends on #5373 EDIT: 'solved' by having the mouseup proc set waitfor = FALSE. In any other language I would be worried about a thread safety violation since it's now diddling the SSclickdrag lists in parallel, but... should be fine I guess. |
MistakeNot4892
added
the
has dependencies
MistakeNot4892
force-pushed
the
feature/melee
branch
4 times, most recently
from
30ef088 to
7e39b3e
Compare
Contributor
Author
|
Depends on #5373. |
MistakeNot4892
force-pushed
the
feature/melee
branch
from
7e39b3e to
f994106
Compare
Fix add_mouse_pointer not updating on icon_index change Add missing attacking cursor definition Add cap to hits per melee attack profile Post-cherry-pick tweaks to charged melee system.
MistakeNot4892
force-pushed
the
feature/melee
branch
from
f994106 to
1e8cfc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening for visibility/diff.
Description of changes
Adds melee charge attacks.
Why and what will this PR improve
More involved melee system.
TODO
Update clickdrag system to tick periodically instead of only on atom change (so that cursor state can be changed properly).Split into separate PR.Authorship
Myself and Penny to date I believe. Will update this closer to merge.
Changelog
Will update closer to merge.