Skip to content

Refactor: Remove unused code and replace raw unit constants with extension functions#192

Merged
Rolf-Smit merged 1 commit into
mainfrom
refactor/cleanup-dead-code-and-unit-extensions
May 7, 2026
Merged

Refactor: Remove unused code and replace raw unit constants with extension functions#192
Rolf-Smit merged 1 commit into
mainfrom
refactor/cleanup-dead-code-and-unit-extensions

Conversation

@Rolf-Smit
Copy link
Copy Markdown
Contributor

No description provided.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 55.55556% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.38%. Comparing base (96baf5c) to head (e9056ca).

Files with missing lines Patch % Lines
...er/presentation/screens/DiveConfigurationScreen.kt 0.00% 4 Missing ⚠️
...bysner/presentation/component/CylinderSizeField.kt 71.42% 2 Missing ⚠️
...ens/planner/cylinders/CylinderPickerBottomSheet.kt 33.33% 2 Missing ⚠️
.../neotech/app/abysner/domain/core/physics/Volume.kt 0.00% 2 Missing ⚠️
...resentation/component/AnnotatedStringExtensions.kt 0.00% 0 Missing and 1 partial ⚠️
...n/screens/planner/gasplan/GasUsageDetailsDialog.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
+ Coverage   69.79%   70.38%   +0.59%     
==========================================
  Files         144      142       -2     
  Lines        8140     8067      -73     
  Branches     1038     1027      -11     
==========================================
- Hits         5681     5678       -3     
+ Misses       1946     1876      -70     
  Partials      513      513              
Flag Coverage Δ
domain 79.34% <60.00%> (+1.45%) ⬆️
presentation 68.25% <54.54%> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Rolf-Smit Rolf-Smit merged commit 43823b9 into main May 7, 2026
4 checks passed
@Rolf-Smit Rolf-Smit deleted the refactor/cleanup-dead-code-and-unit-extensions branch May 7, 2026 13:16
@github-actions github-actions Bot locked and limited conversation to collaborators May 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants