Skip to content

Add hw4_test_coverage solution - #7

Open
Neodelf wants to merge 1 commit into
masterfrom
hw4_test_coverage
Open

Add hw4_test_coverage solution#7
Neodelf wants to merge 1 commit into
masterfrom
hw4_test_coverage

Conversation

@Neodelf

@Neodelf Neodelf commented Feb 10, 2019

Copy link
Copy Markdown
Owner

No description provided.

OrderBy int
}

type SearchClient struct {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported type SearchClient should have comment or be unexported

ErrorBadOrderField = `OrderField invalid`
)

type SearchRequest struct {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported type SearchRequest should have comment or be unexported

}

const (
OrderByAsc = -1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported const OrderByAsc should have comment (or a comment on this block) or be unexported

NextPage bool
}

type SearchErrorResponse struct {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported type SearchErrorResponse should have comment or be unexported

Gender string
}

type SearchResponse struct {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported type SearchResponse should have comment or be unexported

)

type User struct {
Id int

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

struct field Id should be ID

client = &http.Client{Timeout: time.Second}
)

type User struct {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exported type User should have comment or be unexported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant