Fix test failure for ResourceClusterActorTest#861
Merged
Conversation
Andyz26
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
It's a classic Mockito multi-threading race condition. The actor starts in @before and runs background threads. When the test calls when(mantisJobStore.getTaskExecutor(...)) at line 960, Mockito records that invocation — but a background actor thread can call loadAllDisableTaskExecutorsRequests on the mock between Mockito's "record call" and the .thenReturn(...), causing the return value to be associated with the wrong method.
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests