Skip to content

fix(api): ovpn_rw, cleanup pki dir #1491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gsanchietti merged 1 commit into from
Jan 27, 2026
Merged

fix(api): ovpn_rw, cleanup pki dir #1491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/ns-api/files/ns.ovpnrw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,8 +238,9 @@ def add_instance():
return utils.validation_error("instance", "instance_already_exists", instance)

tun = f'tunrw{next_instance}'
if os.path.isdir(f'/etc/openvpn/{instance}'):
return utils.validation_error("instance", "pki_dir_already_exists", instance)
if os.path.isdir(f'/etc/openvpn/{instance}') and instance not in instances:
# cleanup pki dir: the directory may contain rubbish on some corner cases
shutil.rmtree(f"/etc/openvpn/{instance}", ignore_errors=True)

zone_link = ""
fw_link = f"openvpn/{instance}"
Expand Down
Loading