refactor(starknet): change BlockIdentifier from string to typed uint64#3775
Open
0xsamalt wants to merge 1 commit into
Open
refactor(starknet): change BlockIdentifier from string to typed uint64#37750xsamalt wants to merge 1 commit into
0xsamalt wants to merge 1 commit into
Conversation
0xsamalt
commented
Jun 30, 2026
0xsamalt
commented
- Introduces starknet.BlockIdentifier as a named uint64 type with custom UnmarshalJSON that handles both hex string (ex: "0x...") and bare integers.
- Changes PreConfirmedDeltaUpdate.BlockIdentifier and PreConfirmedBlock.BlockIdentifier from string to the new BlockIdentifier type.
- Changes pending.PreConfirmed.BlockIdentifier from string to uint64 (raw, to avoid a circular import from core/pending → starknet).
- Updates all mocks, adapters, and tests to match the new types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.