refactor(pruner): unexport pruneUpto and oldestRetainedBlock

[Ehsan-saradar]

Closes #3671.

PruneUpto and OldestRetainedBlock were exported only so the external pruner_test package could reach them — neither is real cross-package API. Unexported both to pruneUpto / oldestRetainedBlock and moved their direct tests into internal (package pruner) test files, following the existing accessors_internal_test.go pattern. running_event_filter_test.go moves to package pruner too, since it uses pruneUpto to set up state before exercising the exported InitializeRunningEventFilter.

TestPruneBlockDataUpto stays external — it covers the still-exported PruneBlockDataUpto.

Left FindOldestBlockAtOrAfter (also named in the issue) exported on purpose: migration/historyprunner consumes it (and ErrNoBlockInWindow) as production API, so it's not test-only.

Lint and tests pass locally.

[Copilot]

Pull request overview

This PR refactors the pruner package API surface by unexporting helpers that were only public to support the external pruner_test package, and relocates their direct tests into internal (package pruner) test files.

Changes:

• Unexports PruneUpto → pruneUpto and OldestRetainedBlock → oldestRetainedBlock, updating in-package call sites.
• Moves/adjusts tests to package pruner, adding new internal test files for the unexported helpers.
• Updates references in running event filter initialization and retention helpers to use the new unexported names.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
pruner/running_event_filter.go	Updates running event filter initialization to use oldestRetainedBlock.
pruner/running_event_filter_test.go	Switches to package pruner and updates test wiring to use internal helpers.
pruner/retention.go	Uses oldestRetainedBlock internally and updates related doc references.
pruner/retention_test.go	Removes external test of the unexported helper and adjusts assertion text.
pruner/retention_internal_test.go	Adds internal tests for oldestRetainedBlock.
pruner/pruneupto_internal_test.go	Adds internal tests for pruneUpto lifecycle/resume/carve-out behavior.
pruner/pruner.go	Updates pruner implementation to call oldestRetainedBlock / pruneUpto.
pruner/pruner_test.go	Updates comments to reflect the unexported helper name.
pruner/accessors.go	Unexports PruneUpto to pruneUpto and updates internal references.
pruner/accessors_test.go	Keeps external coverage for PruneBlockDataUpto and updates comments accordingly.

Comments suppressed due to low confidence (1)

pruner/pruner.go:404

• This method now calls a package-level helper with the same name (pruneUpto). Although correct, the name collision makes it easy to misread as recursion and can be error-prone during future refactors. Consider renaming either the receiver method or the package-level helper to make call sites unambiguous (e.g., pruneBlocksUpto / pruneUptoInternal).

func (p *Pruner) pruneUpto(ctx context.Context, oldestBlockToKeep uint64) error {
	start := time.Now()

	blocksPruned, oldestKept, err := pruneUpto(
		ctx,
		p.database,
		oldestBlockToKeep,
		p.targetBatchByteSize,
	)

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Ehsan-saradar]

Good catch — fixed in 7f6cabc. Switched it to the exported [PruneBlockDataUpto], which documents the same carve-out and actually resolves on pkg.go.dev, so no internal name leaks into the public docs.

[Ehsan-saradar]

Agreed, same fix applied here — now points at the exported [PruneBlockDataUpto] instead of the unexported helper.

[Ehsan-saradar]

Done here too — linked to [PruneBlockDataUpto]. Thanks for flagging all three.

[Ehsan-saradar]

Also picked up the low-confidence note about the pruneUpto name clash: renamed the Pruner.pruneUpto method to runPruneUpto so it no longer shares a name with the package-level pruneUpto helper it delegates to. The call site reads as a plain call now instead of looking like recursion. Both changes are in 7f6cabc.

[Copilot]

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.