wip: add CBOR fast path decode#3792
Draft
ongyimeng wants to merge 1 commit into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3792 +/- ##
==========================================
+ Coverage 75.16% 75.25% +0.08%
==========================================
Files 438 438
Lines 39577 39633 +56
==========================================
+ Hits 29748 29824 +76
+ Misses 7735 7720 -15
+ Partials 2094 2089 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Felt.UnmarshalCBORpreviously used fxamacker/cbor’s reflection-based decoder. SinceMarshalCBORalways emits a 4-element array ofuint64limbs, decode that shape directly and fall back to the generic decoder for other valid encodings.Benchmark
Baseline using generic CBOR decode vs fast path,
-count=8,benchstat:sec/opimprovement:All results are highly significant:
p=0.000,n=8.B/opandallocs/opare unchanged at approximately 0%, as expected. The fast path avoids reflection CPU overhead incbor.Unmarshal, while decoded felts allocate the same way.