feat(node): mark sequencer flags as experimental#3802
Conversation
Sequencer mode is still incomplete (unstable node identity, no custom network support) but its flags gave no indication of that. Mirror the existing P2P treatment: prefix the --seq.* flag usage strings with EXPERIMENTAL, move them under a "Sequencer (experimental)" help category, and log a warning when sequencer mode is enabled. Closes NethermindEth#3619
There was a problem hiding this comment.
Pull request overview
This PR improves user-facing messaging around sequencer mode by explicitly marking sequencer CLI flags and help categories as experimental, and by adding a startup warning when sequencer mode is enabled (mirroring existing P2P experimental messaging).
Changes:
- Prefixes
--seq.*flag usage strings withEXPERIMENTAL:. - Renames the help category from
SequencertoSequencer (experimental). - Adds a
logger.Warnwhen sequencer mode is enabled.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| node/node.go | Adds a warning log when sequencer mode is enabled to surface experimental status. |
| cmd/juno/usage.go | Renames the sequencer help category to indicate experimental status. |
| cmd/juno/juno.go | Updates sequencer flag usage strings to be prefixed with EXPERIMENTAL:. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ) | ||
|
|
||
| if cfg.Sequencer { | ||
| logger.Warn("Sequencer features enabled. Please note the sequencer is in experimental stage") |
There was a problem hiding this comment.
Kept it as-is on purpose here — it mirrors the existing P2P warning so the two read the same. Rewording just this one would make them diverge, and touching the P2P message feels out of scope for this PR. Happy to align both in a follow-up if we want.
| seqEnUsage = "EXPERIMENTAL: Enables sequencer mode of operation" | ||
| seqBlockTimeUsage = "EXPERIMENTAL: Time to build a block, in seconds" | ||
| seqGenesisFileUsage = "EXPERIMENTAL: Path to the genesis file" | ||
| seqDisableFeesUsage = "EXPERIMENTAL: Skip charge fee for sequencer execution" |
There was a problem hiding this comment.
Good catch, fixed 👍 (that wording was already there — just tidied it while I was on the line).
Description
Closes #3619.
Sequencer mode is still incomplete (the node identity/private key is regenerated on every run, and custom networks aren't supported yet), but its flags gave users no indication of that. This mirrors the existing P2P treatment so the sequencer is honestly surfaced as experimental — no behaviour changes, only informational.
What changed
--seq.*flag usage strings withEXPERIMENTAL:(seqEnUsage,seqBlockTimeUsage,seqGenesisFileUsage,seqDisableFeesUsage).SequencertoSequencer (experimental), matchingP2P (experimental).logger.Warnwhen sequencer mode is enabled, mirroring the P2P warning.Notes
Testing
make lint(diff + full): cleanmake test: pass