feat(tracer): independent trace cancellation and per-operation hop options - #79
Merged
Conversation
…ss-phase cleanup races
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the first phase of the Cache and Network-Transition Lifecycle proposal from docs/CACHE-AND-TRANSITION-LIFECYCLE.md:
cancelActiveTraces(): Decouples active trace cancellation from cache invalidation. Snapshots and cancels in-flight trace handles while preserving cached rDNS, public IP, and ASN data. Traces registered after cancellation begins remain tracked for subsequent operations.TraceOptions: Additive per-operation configuration struct providingmaxHopsoverride (validated against1...255), available viatrace(to:options:)andtraceClassified(to:vpnContext:resolver:options:).trace(to:)andtraceClassified(to:vpnContext:resolver:)entry points so downstream callers and DocC symbol links remain fully backward compatible.networkChanged()delegates directly tocancelActiveTraces()while preserving its full cache invalidation contract.Testing
TraceLifecycleTestscovering:cancelActiveTraces()cancelling active traces without wiping rDNS or cached public IP, and confirmingnetworkChanged()still clears both.TraceOptionsmaxHops bounding trace hops.TraceOptionsout-of-range validation throwingTracerouteError.invalidConfiguration.--warnings-as-errors.swift format lint --strict.