Clean up prompt optimization flow: remove double init, fix DI, deduplicate DTO

[Copilot]

The prompt optimization flow had three structural issues: redundant initialization on every request, Service Locator anti-pattern in plugins, and a duplicated DTO class across two files.

Changes

• Double EnsureInitializedAsync() removed from PromptOptimizationController
OptimizePromptAsync() already calls it internally — the controller was triggering it twice per request.

• PromptOptimizationPlugin constructor injection
  PromptItemService, PromptRangeService, PromptResultService were resolved via SenparcDI.GetServiceProvider().GetRequiredService<T>(). Now injected through constructor parameters.

• PromptCatalyzerPlugin constructor injection
  Same fix — PromptOptimizationService now injected instead of resolved via Service Locator.

• Duplicate PromptOptimizationRequestDto removed from controller
  Identical class was defined in both PromptOptimizationController.cs and PromptOptimizationAppService.cs. Controller now imports the shared definition from OHS.Local.AppService.

// Before: controller resolved deps in constructor body
public PromptOptimizationPlugin(PromptOptimizationAgentBridge bridge)
{
    _bridge = bridge;
    var serviceProvider = SenparcDI.GetServiceProvider();
    _promptItemService = serviceProvider.GetRequiredService<PromptItemService>();
    ...
}

// After: standard constructor injection
public PromptOptimizationPlugin(
    PromptOptimizationAgentBridge bridge,
    PromptItemService promptItemService,
    PromptRangeService promptRangeService,
    PromptResultService promptResultService)
{
    _bridge = bridge;
    _promptItemService = promptItemService;
    ...
}

Original prompt

检查并整理目前提示词“优化”的业务流程、逻辑是怎么样的

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.