test: v0.21.2 insights cost validation

[NeuralEmpowerment]

Validates insights cost fix from syntropic137/syntropic137#554

[NeuralEmpowerment]

Please add a timestamp format note and verify the markdown renders correctly. The date format should follow ISO 8601.

[ghost]

Code Review

Risk: low | Files: 1 | Findings: 4

Summary

This PR adds a single 4-line Markdown file (docs/v0212-insights-validation.md) to record that validation of the v0.21.2 insights cost fix (referencing syntropic137/syntropic137#554) occurred. There are no code changes, no logic modifications, and no Rust test additions. The PR is safe to merge — no security, correctness, or performance concerns — but the documentation stub is too sparse to serve as a meaningful validation artifact. It asserts validation happened without recording any evidence of it.

---

Findings

[?] Validation record provides no evidence of actual validation

docs/v0212-insights-validation.md:3

The file states "Validating insights cost endpoint." but records no test results, no pass/fail outcome, no commands run, no environment details, and no expected vs. actual cost values. A validation document with no validation outcomes cannot serve as evidence that any testing occurred.

Fix: Expand the document to include: (1) what test scenarios were run, (2) expected cost behavior before vs. after the fix, (3) observed outcomes (pass/fail), (4) environment details (OS, app version, configuration), and (5) a link to or excerpt from the referenced fix in syntropic137/syntropic137#554.

---

[?] Commit type test: is misleading — no test code was added

docs/v0212-insights-validation.md:1

Per conventional commits convention, the test: prefix signals that test code is being added or modified. This PR only adds a documentation file. Using docs: would be semantically accurate and consistent.

Fix: Use docs: as the commit prefix (e.g. docs: record v0.21.2 insights cost validation).

---

[~] Cross-reference to the upstream fix is missing from the document body

docs/v0212-insights-validation.md:4

The PR description references syntropic137/syntropic137#554, but this reference does not appear inside the document itself. Anyone reading the file in isolation has no link back to the fix being validated.

Fix: Add a References: syntropic137/syntropic137#554 line inside the file.

---

[~] No established docs/ convention — consider a minimal template

docs/v0212-insights-validation.md:1

This is the first file in docs/, so there is no precedent to follow. If the project will accumulate version-specific validation records, a minimal template or docs/README.md would help future contributors produce consistent artifacts.

---

Verdict

comment

The PR is safe to merge as-is. Before treating this file as a real validation record, consider fleshing out the content with actual test outcomes.

Good that the PR targets docs/ cleanly and does not touch any source code — a disciplined, narrow scope.

[NeuralEmpowerment]

Testing v0.21.2 trigger history wiring - verifying TriggerFired events are now persisted and visible via trigger history endpoint.