You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Ensure attributes & elements can have sinular/plural equivalents generated #46
Could you explain this issue Padraig? It should either be singular or
plural, there shouldn't be the choice. Shouldn't 'ion_channel' just be
changed to 'ion_channels' ?
I see ion_channel but ion_channel_hhs etc. so I think this is still an issue.
Note: I think making this change will change the signature of the NeuroMLDocument constructor etc., so this will be a backwards incompatible breaking change which will need to be clearly announced with an appropriate version bump + changelog entry etc..
Activity
Regenerated for latest version of NeuroML 2 schema
pgleeson commentedon Feb 21, 2014
This is due to this line:
libNeuroML/neuroml/nml/generateds_config.py
Line 96 in 2e10b9a
needed to ensure attribute ionChannel in ChannelDensity becomes ion_channel
vellamike commentedon Feb 24, 2014
Could you explain this issue Padraig? It should either be singular or
plural, there shouldn't be the choice. Shouldn't 'ion_channel' just be
changed to 'ion_channels' ?
On 21 February 2014 18:10, Padraig Gleeson notifications@github.com wrote:
sanjayankur31 commentedon Jun 18, 2021
I see
ion_channelbution_channel_hhsetc. so I think this is still an issue.Note: I think making this change will change the signature of the NeuroMLDocument constructor etc., so this will be a backwards incompatible breaking change which will need to be clearly announced with an appropriate version bump + changelog entry etc..