Render {% pixels %} in the base layout, recover from a consumed cart id; release 1.3.0

[next-devin]

Two Spark bugs found on aptest.29next.store on 2026-09-03, plus the 1.3.0 release bump. Three commits, one per concern.

1. App event trackers never load

Spark-based stores send no storefront events to any installed app. The platform injects each app's event tracker (Google Analytics 4, Google Tag Manager, Klaviyo, Taboola) as a hidden iframe through the builtin {% pixels %} template tag. In Intro Bootstrap that tag is rendered indirectly by {% core_js %} at the end of layouts/base.html. Spark deliberately dropped core_js (jQuery-free design, replaced by assets/js/spark-platform.js) and never re-added {% pixels %}.

Verification. Checked in a browser on aptest.29next.store:

• no iframe[name=customer_event_iframe] elements in the DOM
• no window.customerEventManager
• no app receives page_viewed, product_viewed, product_added_to_cart, or checkout_*

The developer docs (content/docs/storefront/themes/templates/tags.md in developer-docs) say core_js is required in every base layout; this is the part of it Spark still needs.

Platform chain (traced in the platform source). core_js → pixels → customer_event_manager (loads pixels/js/dist/pixels.min.js, creates window.customerEventManager, hooks window.fetch and htmx:afterRequest to read the Analytic-Events response header) + customer_event_iframes (one hidden iframe per active tracker, plus a script that publishes the page's server-side events to each frame on load). Guarded by {% if not disable_pixel %}. All three tags are platform builtins, so no {% load %} is needed, and none of it depends on jQuery.

Points checked against Intro Bootstrap and the platform templates:

• core_js is the only place Intro Bootstrap touches tracking; the rest of that tag is jQuery plumbing Spark already replaced.
• The iframes tag reads the view's object / object_list for product_viewed and category events, not template variables, so Spark templates need nothing extra.
• The GraphQL view attaches Analytic-Events to every response and the manager wraps window.fetch. spark-cart.js calls bare fetch() at call time, so it picks up the patched global; the wrapper preserves the abort-signal init.
• Rendering the block before the theme script stack (Intro renders it after) is deliberate: the fetch hook must exist before the first cart mutation. The iframes still follow the manager, which is the only hard ordering constraint, and footer app hooks still come after.
• Checkout is unaffected: the platform's checkout pages are standalone templates that render {% pixels %} themselves and do not extend the theme layout, so there is no double render.

Change. layouts/base.html gets {% block pixels %}{% pixels %}{% endblock %} immediately before {% block scripts %}. docs/performance-load-order.md and CLAUDE.md document the block.

2. Add-to-cart is dead after a purchase until browser storage is cleared

Reproduced right after an order completed on aptest.29next.store: every add afterwards returned HTTP 200 with

{"addCartLines":{"success":false,"errors":{"nonFieldErrors":[[{"message":"Cart not found.","code":"cart_not_found"}]]},"cart":null}}

Cause. Checkout consumes the cart, but its id stays in sessionStorage and the storefront_cart_id cookie: the order-confirmation page is rendered by the platform, not the theme, so nothing theme-side runs to forget it. SparkCartClient.addToCart only recovered when the request rejected and the message matched isCartExpiredError. This payload resolves, so the .then branch handed back success: false and the create-and-retry path never ran.

Change (assets/js/spark-cart.js).

• isCartNotFoundResult() recognises the resolved shape (code cart_not_found, or a message matching the existing expired-cart heuristic, at any depth of errors).
• addToCart settles the request into an outcome first, then recovers exactly once for either a rejection or a resolved cart_not_found: clear the stored id, createCart, retry with recovery off. A failure inside the retry cannot re-enter the recovery branch.
• getCart clears the stored id when the platform returns cart: null or a not-found error. Badge hydration calls this on the first storefront page after confirmation, so the stale id is gone before the shopper's next add.
• updateCartLines, removeCartLines, addVoucher, removeVoucher clear the id on cart_not_found without recreating (the caller is editing a cart it believes exists), so a stale id cannot leak into the next add.

Tests (tests/js/spark-cart-client.test.js, 14 → 17). The exact aptest payload on the first add asserts createCart and a second addCartLines follow with the new id stored; a second miss returns the platform answer without looping; getCart null/reject and each explicit-id mutation clear the stored id and dispatch nothing.

3. Release 1.3.0

Bumps manifest.json, README.md, and CLAUDE.md to 1.3.0 and promotes the Unreleased changelog section to a dated 1.3.0 heading, with entries for both fixes above and for the changes merged since 1.2.0 that had none (#52, #53, #54). Tag / GitHub release to follow after merge.

Checks

• python3 -m unittest discover -s tests: 61 tests OK (the Tailwind source-guard tests need the tailwindcss binary in the checkout).
• for f in tests/js/*.test.js; do node "$f"; done: all pass.
• scripts/check-templates.py: template integrity gate passed (62 templates).
• make css-check: rebuilt assets/main.css is byte-identical to the committed file, Sass-compat OK.

Related

Velin (Sellmore-Co/velin-theme, a Spark derivative) has the same gaps and received the same fixes separately.

🤖 Generated with Claude Code

[kilo-code-bot]

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	0
WARNING	1
SUGGESTION	0

Issue Details (click to expand)

WARNING

File	Line	Issue
assets/js/spark-cart.js	254	Resolved-result cart-not-found heuristic falls back to isCartExpiredError, whose substring match on 'invalid' will falsely flag unrelated validation errors ("Invalid quantity", "Invalid voucher code") as a missing cart and wipe the stored id.

Files Reviewed (8 files)

• CHANGELOG.md - 0 issues
• CLAUDE.md - 0 issues
• README.md - 0 issues
• manifest.json - 0 issues
• docs/performance-load-order.md - 0 issues
• layouts/base.html - 0 issues
• assets/js/spark-cart.js - 1 issue
• tests/js/spark-cart-client.test.js - 0 issues

Fix these issues in Kilo Cloud

Previous Review Summary (commit 1df9121)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 1df9121)

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	0
WARNING	1
SUGGESTION	0

Issue Details (click to expand)

WARNING

File	Line	Issue
assets/js/spark-cart.js	254	Resolved-result cart-not-found heuristic falls back to isCartExpiredError, whose substring match on 'invalid' will falsely flag unrelated validation errors ("Invalid quantity", "Invalid voucher code") as a missing cart and wipe the stored id.

Files Reviewed (8 files)

• CHANGELOG.md - 0 issues
• CLAUDE.md - 0 issues
• README.md - 0 issues
• manifest.json - 0 issues
• docs/performance-load-order.md - 0 issues
• layouts/base.html - 0 issues
• assets/js/spark-cart.js - 1 issue
• tests/js/spark-cart-client.test.js - 0 issues

Fix these issues in Kilo Cloud

---

_{Reviewed by minimax-m3 · Input: 23.2K · Output: 1.9K · Cached: 239.4K}