Skip to content

Fix blank custom Pages caused by incorrect template context - #61

Merged
next-devin merged 1 commit into
mainfrom
fix-pages-context
Sep 9, 2026
Merged

Fix blank custom Pages caused by incorrect template context#61
next-devin merged 1 commit into
mainfrom
fix-pages-context

Conversation

@next-devin

Copy link
Copy Markdown
Contributor

Custom Pages returned HTTP 200 with empty document titles, breadcrumbs, headings, and body content because Spark referenced flatpage, while NEXT supplies the object as page. Replace the four references in templates/pages/page.html and record the fix in the unreleased changelog. Page content now renders with Account Only mode enabled as well.

Validation:

  • All 67 existing Python tests pass.
  • Committed CSS compatibility and CSS drift checks pass; CSS is unchanged.
  • Verified the same template patch on three deployed custom Pages at 1440px desktop and 390px mobile: headings and full content render, with no horizontal overflow. Store-specific screenshots are retained locally and omitted from this public PR.

@next-devin
next-devin marked this pull request as ready for review September 9, 2026 02:02
@kilo-code-bot

kilo-code-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

The PR replaces the four flatpage references in templates/pages/page.html with the platform-provided page context variable and records the fix under a new ## Unreleased section in CHANGELOG.md. The change is minimal and surgical: only the wrong identifier is touched, surrounding markup and class names are unchanged, and grep confirms no remaining flatpage references in the repo. The changelog entry is consistent with prior entry style (single bullet, root cause + user impact, no extraneous framing).

Files Reviewed (2 files)
  • templates/pages/page.html
  • CHANGELOG.md

Reviewed by minimax-m3 · Input: 24.3K · Output: 1.6K · Cached: 180.7K

@next-devin
next-devin merged commit 3728933 into main Sep 9, 2026
2 checks passed
@next-devin
next-devin deleted the fix-pages-context branch September 9, 2026 02:04
@next-devin next-devin mentioned this pull request Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant