Skip to content

fix(site): resolve 404 for favicon.ico and configure Eleventy passthrough - #664

Merged
jbampton merged 7 commits into
NextCommunity:mainfrom
koushik4475:fix/issue-134-favicon
Nov 6, 2026
Merged

jbampton merged 7 commits into
NextCommunity:mainfrom
koushik4475:fix/issue-134-favicon

Conversation

@koushik4475

Copy link
Copy Markdown
Member

Summary & Fix Rationale

Resolves 404 error when requesting https://nextcommunity.github.io/favicon.ico. Closes #134.

Changes Made:

  1. Favicon Asset Added: Added avicon.ico in both root src/ and src/assets/img/.
  2. Eleventy Passthrough: Configured eleventyConfig.addPassthroughCopy({ 'src/favicon.ico': 'favicon.ico' }) in .eleventy.js to ensure the file is outputted directly to the root of _site/.
  3. HTML Link Tag: Added to src/_includes/layouts/base.njk.

Co-authored with @codedude1010.

Closes NextCommunity#134

Co-authored-by: codedude1010 <emailsendervisionexus@gmail.com>
@deepsource-io

deepsource-io Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 34ed948...5e78384 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

Important

Some issues found as part of this review are outside of the diff in this pull request and aren't shown in the inline review comments due to GitHub's API limitations. You can see those issues on the DeepSource dashboard.

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript Nov 6, 2026 10:32p.m. Review ↗
Secrets Nov 6, 2026 10:32p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@jbampton jbampton self-assigned this Oct 17, 2026
@jbampton jbampton added this to the Hacktoberfest 2026 milestone Oct 17, 2026
@jbampton jbampton moved this to In progress in Next Oct 17, 2026
@jbampton
jbampton requested a balanced review from Copilot October 17, 2026 23:37
@jbampton jbampton moved this from In progress to Review in progress in Next Oct 17, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Both favicon assets contain JPEG data rather than the declared ICO format.

1 open issue
What changed in this PR

Addresses issue #134 by publishing a root favicon URL and referencing it from the shared site layout.

Changes:

  • Adds Eleventy passthrough copying for /favicon.ico.
  • Adds icon and shortcut-icon links to the shared layout.
File Description
src/​_includes/​layouts/​base.njk References the root favicon.
.eleventy.js Copies the favicon to the output root.

Review effort: Balanced

Comment thread .eleventy.js Resolved
@jbampton
jbampton marked this pull request as draft October 18, 2026 00:05
Resolves Copilot review feedback on PR NextCommunity#664. Both src/favicon.ico and src/assets/img/favicon.ico are now valid 32-bit ICO files matching image/x-icon mime type.

Co-authored-by: codedude1010 <emailsendervisionexus@gmail.com>
@koushik4475

Copy link
Copy Markdown
Member Author

Replaced both src/favicon.ico and src/assets/img/favicon.ico with genuine 32-bit ICO binaries (header 00 00 01 00) matching the declared image/x-icon format. Thank you for the review!

@jbampton

Copy link
Copy Markdown
Member

@deepsourcebot review

@jbampton
jbampton requested a balanced review from Copilot October 31, 2026 05:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain, and the changes address the missing root-level favicon through passthrough configuration and shared-layout references.

1 open issue

Review effort: Lite

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified, and the changes directly address the root-level favicon 404 through passthrough copying and shared-layout references.

No open issues 🎉

1 resolved since last review

Review effort: Lite

@jbampton
jbampton marked this pull request as ready for review November 6, 2026 22:35
@jbampton jbampton removed the on hold label Nov 6, 2026

@jbampton jbampton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🏂

@github-project-automation github-project-automation Bot moved this from Review in progress to Reviewer approved in Next Nov 6, 2026
@jbampton
jbampton merged commit ce13e64 into NextCommunity:main Nov 6, 2026
15 of 16 checks passed
@github-project-automation github-project-automation Bot moved this from Reviewer approved to Done in Next Nov 6, 2026
@jbampton jbampton added the paid label Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

404 not found for favicon.ico

4 participants