Skip to content

fix: allow dependency install from webui#238

Merged
EterUltimate merged 2 commits into
mainfrom
codex/fix-dependency-install-deadlock
Jul 6, 2026
Merged

fix: allow dependency install from webui#238
EterUltimate merged 2 commits into
mainfrom
codex/fix-dependency-install-deadlock

Conversation

@EterUltimate

@EterUltimate EterUltimate commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fix the dependency-install deadlock by moving the manual install contract to the WebUI Dashboard confirmation flow and bump the plugin version to 3.5.2 for release.

Changes

  • Allow dependency installation after explicit WebUI confirmation without requiring the old system_settings source.
  • Send manual_confirmed: true and source: webui_settings from the Solid Dashboard settings page.
  • Add frontend and integration regressions for WebUI dependency install confirmation, including the no-old-source path.
  • Stabilize the metadata logging assertion so the full pytest suite works with the AstrBot/logger output path.
  • Update dependency-install docs and rebuild embedded dashboard assets.
  • Bump metadata.yaml, __version__, README badges, and WebUI package version to 3.5.2.

Related Issues

Closes #237

Type of Change

  • Bug fix
  • New feature
  • Refactoring (no functional changes)
  • Documentation update
  • Other:

Checklist

  • Code follows the project's coding style
  • Self-reviewed the code changes
  • No new warnings or errors introduced
  • Tested on SQLite mode
  • Tested on MySQL mode (if applicable)

Validation:

  • pnpm test -- --runInBand
  • pnpm run typecheck
  • pnpm run build
  • python -m pytest --no-cov
  • python -m pytest tests\integration\test_config_dependency_install.py tests\integration\test_package_imports.py
  • python -m py_compile core\page_api.py webui\blueprints\config.py
  • python C:\Users\zacza\.codex\skills\skill-astrbot-dev\scripts\pre_review_check.py C:\Users\zacza\Desktop\x\self_learning_EterU
  • git diff --check

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @EterUltimate, your pull request is larger than the review limit of 150000 diff characters

@EterUltimate EterUltimate merged commit 12693a3 into main Jul 6, 2026
19 checks passed
@EterUltimate EterUltimate deleted the codex/fix-dependency-install-deadlock branch July 6, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

配置可能存在双份存储不同步,导致 PostgreSQL 连接读取旧配置

1 participant