Skip to content

fix(website): Snack playground never ran because dependencies were URL-encoded #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NikPnevmatikos merged 1 commit into from
Sep 11, 2026
Merged

fix(website): Snack playground never ran because dependencies were URL-encoded #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions website/src/components/SnackEmbed.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,17 @@ const FILES = encodeURIComponent(
}),
);

const DEPENDENCIES = encodeURIComponent(
[
'@nikpnevmatikos/html-renderer',
'@nikpnevmatikos/html-renderer-video',
// Deep imports must be listed as their own dependency for Snack to resolve them.
'@nikpnevmatikos/html-renderer-video/expo',
'expo-video',
'expo-status-bar',
].join(','),
);
// Not URL-encoded on purpose: embed.js decodes `data-snack-files` before
// posting it to the iframe but forwards `data-snack-dependencies` verbatim,
// and Snack does not decode it on arrival.
const DEPENDENCIES = [
'@nikpnevmatikos/html-renderer',
'@nikpnevmatikos/html-renderer-video',
// Deep imports must be listed as their own dependency for Snack to resolve them.
'@nikpnevmatikos/html-renderer-video/expo',
'expo-video',
'expo-status-bar',
].join(',');

// expo-video is only bundled into Snack's runtime from SDK 56 onwards.
const SDK_VERSION = '56.0.0';
Expand Down
Loading