Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and result
On a Windows PC with an RTX 5090 and Intel UHD Graphics 770, the desktop Monitor stayed at
0.0 Wh: the RTX reported power, but the Intel GPU did not. The host discarded the total when any detected GPU lacked a power reading.The host now sums valid power readings for its power display and energy meter. Other GPU metrics are unchanged.
Approach
Use reported GPU power and power-limit readings for those two totals. Add a regression test for a metered GPU beside an unmetered iGPU, multiple metered GPUs, and no available readings.
Validation
Tested on Strata 0.2.7 base plus
4cb31c1a, Windows, RTX 5090 and Intel UHD Graphics 770.Passed:
node --test tests/energy-meter.test.mjs tests/monitor-dashboard.test.mjs tests/monitor-host-sensors.test.mjs tests/sensor-pace.test.mjsinapps/host(22 tests);npm run typecheck;npm run build; desktop app built withnpm run dev. In the desktop Monitor, energy rose from0.5to0.9to1.2 Whwhile the RTX reported power and the Intel GPU reported none.Failed: Full
npm teston Windows: 1,123 passed, 1 failed, 102 skipped. Inpowershell-utf8.test.mjs, Node crashes (0xC0000409) while removing a Cyrillic-named temporary folder. The same failure reproduces on unchanged upstream5e8a4ccaunder the same conditions.Not run: Other GPU combinations or model inference. No native engine code changed, so backend builds were not run.
Limits
Energy remains an estimate from sampled GPU power. It covers only GPUs with available readings and resets when the host restarts.