Fix SKILL.md scaffold and wiring-only unit test#11
Open
JoeCardoso13 wants to merge 1 commit intomainfrom
Open
Conversation
The template shipped a fully-populated SKILL.md with hardcoded list_items/get_item tool names, and test_skill_resource_readable asserted those names. This broke the build-mcpb pipeline at Phase 3 when tools were replaced with real ones but SKILL.md wasn't updated until Phase 5. SKILL.md is now a structural scaffold (frontmatter + section headings, no tool names). The unit test asserts the resource is non-empty and has the expected structure, without assuming any specific tool names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SKILL.md(hardcodedlist_items/get_item) with a TODO scaffold — frontmatter + section headings, no tool namestest_skill_resource_readablefrom asserting specific tool names to asserting non-empty content with expected structure (## Toolsheading)This fixes a break in the build-mcpb pipeline where Phase 3 (Implement & Verify) replaces template tools with real ones, but SKILL.md isn't customized until Phase 5 (Embed Skill). The unit test was asserting tool names that no longer existed.
Related: NimbleBrainInc/contributor-toolkit#43
Test plan
uv run pytest tests/ -v— all 25 tests pass with the scaffold SKILL.md