Architecture review fixes: game rules off the event bus, save v4, game-over screens - #13

Merged

NoHudd merged 16 commits into

devfrom

fix/arch-review-todo

Sep 29, 2026

Commits on Sep 29, 2026

fix(ui): death drains from the fight, only a death shows GAME OVER

NoHudd
and
claude
committed
b2ef616
test: run the suite strict so swallowed failures fail tests

NoHudd
and
claude
committed
66bbe40
fix(save): keep armor, status effects and difficulty across save/load

NoHudd
and
claude
committed
bb80095
fix(load): post-win restore gives a fully working run

NoHudd
and
claude
committed
a7dfc95
refactor: arriving in a room is a direct call, not an event reaction

NoHudd
and
claude
committed
ac27368
refactor: a fight's outcome is handled by one direct call chain

NoHudd
and
claude
committed
8212257
refactor: an enemy's death is handled by one direct call

NoHudd
and
claude
committed
0920d01
refactor: game-over "new game"/"restore" call the engine directly

NoHudd
and
claude
committed
939d7bb
build: mypy passes on a fresh clone without config/settings.py

NoHudd
and
claude
committed
62aef85
chore: remove code paths that never run (review option 7)

NoHudd
and
claude
committed
b53bc19
refactor: the engine owns the game mode, and the transition table is enforced

NoHudd
and
claude
committed
fcb6d2a
refactor: one stats/inventory refresh per command

NoHudd
and
claude
committed
376aaf4
refactor: the running game loads its world through load_all() + link()

NoHudd
and
claude
committed
800f6ed
refactor: the event contract and view models move into engine/

NoHudd
and
claude
committed
85379e4
feat(tutorial): flash the Echo panel when the tutorial starts

NoHudd
and
claude
committed
0a426bb
Merge remote-tracking branch 'origin/dev' into fix/arch-review-todo
NoHudd
committed
27f84ca

Navigation Menu

Architecture review fixes: game rules off the event bus, save v4, game-over screens - #13

Architecture review fixes: game rules off the event bus, save v4, game-over screens#13
NoHudd merged 16 commits into
devfrom
fix/arch-review-todo

Commits on Sep 29, 2026

fix(ui): death drains from the fight, only a death shows GAME OVER

test: run the suite strict so swallowed failures fail tests

fix(save): keep armor, status effects and difficulty across save/load

fix(load): post-win restore gives a fully working run

refactor: arriving in a room is a direct call, not an event reaction

refactor: a fight's outcome is handled by one direct call chain

refactor: an enemy's death is handled by one direct call

refactor: game-over "new game"/"restore" call the engine directly

build: mypy passes on a fresh clone without config/settings.py

chore: remove code paths that never run (review option 7)

refactor: the engine owns the game mode, and the transition table is enforced

refactor: one stats/inventory refresh per command

refactor: the running game loads its world through load_all() + link()

refactor: the event contract and view models move into engine/

feat(tutorial): flash the Echo panel when the tutorial starts

Merge remote-tracking branch 'origin/dev' into fix/arch-review-todo