Merged
Conversation
…ar-detail-api # Conflicts: # presentation/src/main/java/com/sopt/presentation/calendar/CalendarRoute.kt # presentation/src/main/java/com/sopt/presentation/calendar/CalendarViewModel.kt
…ar-detail-api # Conflicts: # presentation/src/main/java/com/sopt/presentation/calendar/CalendarViewModel.kt
gaeulzzang
approved these changes
Apr 9, 2025
Contributor
gaeulzzang
left a comment
gaeulzzang
left a comment
There was a problem hiding this comment.
코리 하나만 반영하면 될듯!!!
아니 피그마 디자인에 하루종일 뭐냐구 ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ 하루종일이 없는데 ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ
| onItemClick = { id -> | ||
| clickAppointmentId = id | ||
| calendarViewModel.getConfirmedDetail(clickAppointmentId) | ||
| navController.navigate(SCHEDULE_DETAIL) |
Contributor
There was a problem hiding this comment.
P1: 빈 화면 위에 다이얼로그 뜨는 것보다 그룹 아이템이 보이는 상태에서 뜨는게 나을 것같아서 이렇게 수정해주쇼!!
Suggested change
| navController.navigate(SCHEDULE_DETAIL) | |
| when (getConfirmedDetailState) { | |
| is UiState.Success -> { | |
| navController.navigate(SCHEDULE_DETAIL) | |
| } | |
| else -> Unit | |
| } |
youjin09222
approved these changes
Apr 9, 2025
core/src/main/java/com/sopt/core/util/time/CalculateTimeFromLocalDate.kt
Show resolved
Hide resolved
presentation/src/main/java/com/sopt/presentation/calendar/CalendarViewModel.kt
Show resolved
Hide resolved
presentation/src/main/java/com/sopt/presentation/calendar/CalendarViewModel.kt
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ 𝗖𝗵𝗲𝗰𝗸-𝗟𝗶𝘀𝘁
📌 𝗜𝘀𝘀𝘂𝗲𝘀
📎 𝗪𝗼𝗿𝗸 𝗗𝗲𝘀𝗰𝗿𝗶𝗽𝘁𝗶𝗼𝗻
📷 𝗦𝗰𝗿𝗲𝗲𝗻𝘀𝗵𝗼𝘁
2025-04-10.4.07.35.mov
💬 𝗧𝗼 𝗥𝗲𝘃𝗶𝗲𝘄𝗲𝗿𝘀
캘린더 팝업 약속 상세 조회 부분에서 API path에 이슈가 있어서 연결된 화면은 확인이 불가능한 상태...이지만
일단 API 필드에 따른 형식이나 UI는 다 맞춰놓아서 별다른 문제 없다면 아마 잘될거예요
약속 생성 - 확정 로직 너무 복잡하네요;;;