ENT-11346: Added BufferAppendFileContent() - #295
Merged
Conversation
|
There was an error running your pipeline, see logs for details. |
Contributor
Author
|
@larsewi please review |
larsewi
reviewed
Aug 19, 2026
larsewi
left a comment
larsewi
left a comment
Contributor
There was a problem hiding this comment.
Change this to a do-while-loop and use ((size_t) n_read < sizeof(bytes)) as the loop condition.
Reads from a file descriptor until end of file and appends everything to the buffer. cf-reactor needs this to collect the output of the cfbs commands it spawns, and had its own copy of the loop. Ticket: ENT-11346 Changelog: None Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
aleksandrychev
force-pushed
the
ENT-11346
branch
from
August 20, 2026 07:51
b9e046e to
79ed478
Compare
|
There was an error running your pipeline, see logs for details. |
Contributor
Author
|
@larsewi please merge, I don't have access |
Contributor
|
Please update the submodule in core repo, or wait for the github workflow to do it. I think it runs once a day. |
Contributor
I did it here cfengine/core#6329 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reads from a file descriptor until end of file and appends everything to the buffer. cf-reactor needs this to collect the output of the cfbs commands it spawns, and had its own copy of the loop.
Ticket: ENT-11346
Changelog: None