feat: show each brand's bootloader policy, with a source - #12
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Feature
Overview
Section 4 of the android-rom-compat card asks for a brand level bootloader field, because "does the
bootloader unlock" is in the strapline and it's Unknown on 609 of 708 devices. Most of that is brand
policy rather than per-device fact.
Brands can now carry a
bootloaderblock withnotesand asource. It shows on the brand page andunder Bootloader on every device page, and it does not change what a device's own
unlocksays.That last bit is a deliberate departure from the card, which wanted devices to inherit the brand's
value when their own is
unknown. Inheritance only holds for Google and Fairphone,, which is 21 of the 609. Samsung keys off the One UI version, Motorola off the chipset class, Xiaomi off Android One vsHyperOS, OnePlus off region, and Sony excludes carrier models, so inheriting would put a confident
wrong answer on a few hundred pages to fix 21. Prose next to the value says the same thing without
claiming a per-device answer.
Only Google and Fairphone are filled in, and only those two, because I could get a source I'd actually
read for them. Everything else stays unknown, which is what the card asks for. Google is off
source.android.com, which says Nexus and Pixel from 2015 on takefastboot flashing unlockand thata carrier locked phone can't be unlocked. Fairphone's is thier own support article. Motorola's page
404s, Fairphone's support site and Xiaomi's unlock page both refuse a script (Xiaomi's is all JS
anyway), so the rest wants a human with a browser.
Devices get an optional
bootloader.sourcetoo, same reasoning - everything needs a source. Nothing indata/devices/sets one yet, so I added one to the Pixel 9a temporarily, built, checked itrendered, and took it back out.
Issue Number
Section 4 of NotAFlightRisk/tasks#26. Sections 1 and 4's inherit-or-not question are both still open.
Additional Info
Codex caught one real thing and it was already there before this PR: ajv's
uriformat is looserthan Node's URL parser, so
https://example.com:99999passesnpm run validateand then throwsERR_INVALID_URLwhen a page reads a hostname off it.brand.websiteandstock.sourcehave hadthat hole all along. Second commit registers a
linkformat that just asksURL.canParse, so thevalidator now agrees with the thing doing the rendering, and bad data gets "isn't a full link"
instead of killing the build.
No screenshot, it's two lines of prose. Here's what the Pixel 9a's Bootloader section reads as now,
out of
dist:56 device pages pick up a policy line (51 Google + 5 Fairphone), the other 652 are untouched, and I
checked a Samsung page to be sure it still just says Unknown.
Tests went 85 to 88. Two of the three are proper regression tests - reverting the brands schema turns
"has to say where it came from" red, and swapping
linkback touriturns the bad-link assertionred. The model one isn't: it passes either way, because the model already spreads the brand through.
Its there to pin the no-inheritance decision, so if anyone does wire inheritance up later it goes red
and they have to mean it.