Repository navigation
feat(pets): each pet speaks in its own voice, at seven moments - #37
Conversation
…and holiday flavours Signed-off-by: NovusEdge <novusedge0@gmail.com>
Signed-off-by: NovusEdge <novusedge0@gmail.com>
Signed-off-by: NovusEdge <novusedge0@gmail.com>
Signed-off-by: NovusEdge <novusedge0@gmail.com>
…urns and on compaction Signed-off-by: NovusEdge <novusedge0@gmail.com>
Setups are now written as format 2, so a deliberate needs-you,fail,done choice survives re-reading. The changelog also notes that Haiku lines use each pet's voice. Signed-off-by: NovusEdge <novusedge0@gmail.com>
Signed-off-by: NovusEdge <novusedge0@gmail.com>
Signed-off-by: NovusEdge <novusedge0@gmail.com>
…dropped hello The greeted session id lives in $.state, which survives a hot reload. A hello dropped because the pane was not yet reported shown sets helloDue again so the next draw retries. Renames the local red in the Pane render hook to reduced; it shadowed the module's red. Signed-off-by: NovusEdge <novusedge0@gmail.com>
The row beside the pet was as tall as the sprite, so a 2x2 px pet's one-row strip clipped the three-row bubble away. Signed-off-by: NovusEdge <novusedge0@gmail.com>
Signed-off-by: NovusEdge <novusedge0@gmail.com>
A done turn that edited no file picked "done. {file} looks better" and
showed an ellipsis mid-sentence. When every line has an empty slot, the
whole pool stays, so a fail with no count still speaks.
Signed-off-by: NovusEdge <novusedge0@gmail.com>
Signed-off-by: NovusEdge <novusedge0@gmail.com> # Conflicts: # CHANGELOG.md
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (26)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThis change adds pet-specific dialogue and voice, seven bubble moments, format-2 setup and pet-file support, and pane sizing that accounts for bubble height. It also updates bubble delivery, landing and studio references, documentation, and tests. ChangesPet dialogue and bubble behavior
Priority: ➖ Normal Estimated code review effort: 4 (Complex) | ~50 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant ModelEvents
participant momentOf
participant registerSay
participant linesPool
participant Pane
ModelEvents->>momentOf: model state and event
momentOf->>registerSay: selected moment and variables
registerSay->>linesPool: pet lines, moment, and flavours
linesPool->>registerSay: candidate dialogue lines
registerSay->>Pane: bubble text and moment
Merge Risk: ⚪ Minimal · up to No issue requiring a change before merge was established; proceed with normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 31.25% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 32 functions across 22 files. (4 skipped: 4 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. I’m a rabbit, and I hop through the day, Comment |
Every pet used to say Clawd's lines from one table of three moods, three lines each, and the Haiku prompt always called the speaker Clawd. Each pet now has its own voice, speaks at more moments, and picks up lines by time of day.
What changed
hooks/lines.tsholds a line table for each of Clawd, the robot and the egg, with at least six lines per moment.clawd-shinyuses Clawd's table.FAULT: 3 TESTS,REPAIR SUCCESSFUL.).Four new moments sit beside done, fail and needs-you:
greenhellolong-donecompacthooks/moments.tsdecides which moment an event speaks.Keys like
done@night,hello@morningandhello@christmasadd flavour lines by daypart, on Fridays, and on the holiday outfit dates. Bubble lines whose{file},{n}or{command}slot has no value are skipped.Pet files with
"format": 2can carrylinesand a Haikuvoice, and validation names the offending key. Glowup 0.12 and earlier refuse format 2.Haiku lines speak in the pet's voice. Hello and compact never call Haiku, so they cannot use up a turn's one Haiku call.
The default
bubbles.moodsturns on all seven moments. Setups are now saved as"format": 2. A setup saved before this release that still holds the old default (needs-you,fail,done) gets all seven, and choosing those three on purpose now sticks.The studio labels the four new mood checkboxes, and the landing page reads the new tables.
Fixed: a custom pet shorter than its bubble cut the bubble off, because the pane's pet row was only as tall as the sprite. This bug was on main as well.
Testing
pnpm testpasses 893 of 893 on the branch merged with main,tscis clean, anddocs/webbuilds.--plugin-dir:FAULT: 3 TESTS, thenREPAIR SUCCESSFUL.on a passing run in the next turn;CONTEXT COMPRESSED.after/compact;doneline, including the 2×2 pet from the docs example.Summary by CodeRabbit
New Features
Bug Fixes