Fix judge of custom server from findgamebycode#101
Open
NikoCat233 wants to merge 1 commit intoNuclearPowered:masterfrom
Open
Fix judge of custom server from findgamebycode#101NikoCat233 wants to merge 1 commit intoNuclearPowered:masterfrom
NikoCat233 wants to merge 1 commit intoNuclearPowered:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server issued by the new FindGameByCode can be different from the one set in ServerManager.
This means that if we find a game on officials, but ServerManager's region is set to a modded server, dtls nonce will be skipped, thus resulting in auth failure.
This pr attempts to ease the issue by logging the FindGameByCode response, record the ip and the region name and compare it on actual joining the server.
The code does not seem to fit in the current codebase so changes are welcome.