i18n(vi): add Vietnamese (vi) locale#154
Closed
ThaiTrevor wants to merge 2 commits into
Closed
Conversation
- Add locales/vi.json with all 217 message keys translated from en.json - Register `vi` in supportedLocales and localeMeta (ltr, "Tiếng Việt") - Wire viMessages into messagesByLocale in lib/i18n.ts Closes O2sa#133 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
@ThaiTrevor is attempting to deploy a commit to the osama's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for the pull request! ✅ A maintainer will review this soon. Please be patient while we take a look. 🙌 |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
O2sa
requested changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Vietnamese (
vi) localization to DevImpact, alongside the existing English and Arabic locales. This addresses issue #133's goal of standardizing localization config to simplify adding new languages by demonstrating the full path for a new locale: a JSON message file plus minimal entries inlib/i18n-core.tsandlib/i18n.ts.Changes
locales/vi.json— 217 message keys translated fromlocales/en.json, formal Vietnamese (bạnform), full diacritics, all{placeholder}tokens preserved verbatim.lib/i18n-core.ts: addvitosupportedLocalesand alocaleMetaentry ({ dir: "ltr", label: "Tiếng Việt" }).lib/i18n.ts: importviMessagesand register it inmessagesByLocale.Translation notes
DevImpact,GitHub,Pull Request,Repository,Issue,PR,commit,merge,fork,token,API,repo.webhook-style policy).finalScore = repoScore * 0.45 + ...) kept verbatim.{name},{seconds},{username},{score},{other},{diff},{winner},{language},{title},{repo},{value},{number},{user1},{user2}) preserved byte-for-byte.Validation
python -m json.tool locales/vi.json→ valid JSONen217 keys ↔vi217 keys, zero missing/extraCloses #133
🤖 Generated with Claude Code