[19.0][MIG] account_*: analysis annotations for simple submodules#5647
Open
dnplkndll wants to merge 1 commit into
Open
[19.0][MIG] account_*: analysis annotations for simple submodules#5647dnplkndll wants to merge 1 commit into
dnplkndll wants to merge 1 commit into
Conversation
OCA-git-bot
added
mod:openupgrade_scripts
Author
|
@remi-filament — convention-clean per |
dnplkndll
force-pushed
the
19.0-mig-account-trivial
branch
from
975344b to
7fa5d04
Compare
Author
|
@MiquelRForgeFlow — ready for review |
hbrunn
requested changes
May 26, 2026
Member
hbrunn
left a comment
hbrunn
left a comment
There was a problem hiding this comment.
the ones where there's actually nothing to do should have Nothing to do in the second column and nothing in the third
| | account |Done | | | ||
| +---------------------------------------------------+----------------------+-------------------------------------------------+ | ||
| | account_check_printing | | | | ||
| | account_check_printing |Done |Nothing to do | |
Member
There was a problem hiding this comment.
there's a noupdate_changes.xml file that needs to be loaded
| @@ -0,0 +1,10 @@ | |||
| ---Models in module 'account_check_printing'--- | |||
|
|
|||
| # NOTHING TO DO | |||
Member
There was a problem hiding this comment.
don't add this for empty lists, also below
dnplkndll
force-pushed
the
19.0-mig-account-trivial
branch
6 times, most recently
from
e143373 to
1f75f08
Compare
- account_check_printing: noupdate records reloaded in post-migration. - account_debit_note, account_edi_proxy_client, account_peppol_advanced_fields: annotation-only, nothing to do.
dnplkndll
force-pushed
the
19.0-mig-account-trivial
branch
from
1f75f08 to
c6071ea
Compare
dnplkndll
added a commit
to ledoent/OpenUpgrade
that referenced
this pull request
May 30, 2026
Align the annotation guidance with hbrunn's review on OCA#5647 ('don't add this for empty lists') — empty work-file sections are left blank; only populated sections get an inline # DONE / # NOTHING TO DO marker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of account_check_printing, account_debit_note, account_edi_proxy_client, account_peppol_advanced_fields from 18.0 to 19.0.
Non-mechanical adaptations worth flagging
noupdate_changes.xmlcontains active<record>entries; addedpost-migration.pywithopenupgrade.load_data(…, 'noupdate_changes.xml')so the noupdate records are reloaded on upgrade.