-
-
Notifications
You must be signed in to change notification settings - Fork 110
[19.0][MIG] fleet_vehicle_fuel_type_ethanol: Migration from 18.0 #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.0
Are you sure you want to change the base?
[19.0][MIG] fleet_vehicle_fuel_type_ethanol: Migration from 18.0 #212
Conversation
Currently translated at 100.0% (10 of 10 strings) Translation: fleet-12.0/fleet-12.0-fleet_vehicle_fuel_type_ethanol Translate-URL: https://translation.odoo-community.org/projects/fleet-12-0/fleet-12-0-fleet_vehicle_fuel_type_ethanol/pt_BR/
Currently translated at 100.0% (5 of 5 strings) Translation: fleet-15.0/fleet-15.0-fleet_vehicle_fuel_type_ethanol Translate-URL: https://translation.odoo-community.org/projects/fleet-15-0/fleet-15-0-fleet_vehicle_fuel_type_ethanol/it/
Currently translated at 100.0% (4 of 4 strings) Translation: fleet-16.0/fleet-16.0-fleet_vehicle_fuel_type_ethanol Translate-URL: https://translation.odoo-community.org/projects/fleet-16-0/fleet-16-0-fleet_vehicle_fuel_type_ethanol/es/
Currently translated at 100.0% (4 of 4 strings) Translation: fleet-16.0/fleet-16.0-fleet_vehicle_fuel_type_ethanol Translate-URL: https://translation.odoo-community.org/projects/fleet-16-0/fleet-16-0-fleet_vehicle_fuel_type_ethanol/sv/
|
Thanks for the contribution and welcome to OCA 🙂 Just a small note about the commit structure, following the official migration guide. According to the Migration to version 19.0 wiki, the expected flow is to first commit only the pre-commit auto-fixes, and then have a separate migration commit. In the current state of the PR, the changes that should belong to the migration (for example, version bump and other migration tasks) were included in the [IMP] : pre-commit auto fixes commit. Because of that, there is effectively no dedicated [MIG] : Migration to 19.0 commit. Could you please adjust the commits so that: the pre-commit commit contains only formatting / linter auto-fixes, and the actual migration changes are moved into a separate [MIG] commit, as described in the wiki? This helps keep the history clean and makes reviews and future migrations much easier. |
231f8ce to
12c64f3
Compare
|
Thank you for the welcome and for the feedback 🙂 |
|
@DenerWilliam drop this please
|

Up to 19.0