[19.0] mail_composer_cc_bcc: Migration to 19.0#104
Open
cyrilmanuel wants to merge 38 commits intoOCA:19.0from
Open
[19.0] mail_composer_cc_bcc: Migration to 19.0#104cyrilmanuel wants to merge 38 commits intoOCA:19.0from
cyrilmanuel wants to merge 38 commits intoOCA:19.0from
Conversation
…ents when no cc or bcc
Currently translated at 83.3% (15 of 18 strings) Translation: social-16.0/social-16.0-mail_composer_cc_bcc Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_composer_cc_bcc/es/
Currently translated at 100.0% (18 of 18 strings) Translation: social-16.0/social-16.0-mail_composer_cc_bcc Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_composer_cc_bcc/es/
Currently translated at 100.0% (18 of 18 strings) Translation: social-16.0/social-16.0-mail_composer_cc_bcc Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_composer_cc_bcc/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-17.0/social-17.0-mail_composer_cc_bcc Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_composer_cc_bcc/
Currently translated at 100.0% (17 of 17 strings) Translation: social-17.0/social-17.0-mail_composer_cc_bcc Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_composer_cc_bcc/it/
…onstraint "unique_mail_message_id_res_partner_id_if_set" when adding the same user to CC field that is already set as a follower
### This changes 1. Refactor _generate_template_recipients 2. Fix invalid-email-address for Bcc - In standard, Bcc key in dict message was stripped in https://github.com/odoo/odoo/blob/4394940a09900aa5b42cbc05355880598608d1b6/odoo/addons/base/models/ir_mail_server.py#L676 - Duplicate the key to retain for later assertion
Default behavior in ´mail´ is that _prepare_outgoing_list() returns mails with email_to as a LIST. ´mail_tracking´ is dependent on this behvaior, and it converts LIST to STRING using COMMASPACE. Without the fix in this commit, the combination of ´mail_composer_cc_bcc´ and ´mail_tracking´ will produce email_to with comma between each character.
Currently translated at 100.0% (17 of 17 strings) Translation: mail-18.0/mail-18.0-mail_composer_cc_bcc Translate-URL: https://translation.odoo-community.org/projects/mail-18-0/mail-18-0-mail_composer_cc_bcc/it/
cyrilmanuel
force-pushed
the
19.0-mail_composer_cc_bcc
branch
from
73bfe5f to
af5d8f3
Compare
imlopes
force-pushed
the
19.0-mail_composer_cc_bcc
branch
from
e653654 to
6442af0
Compare
vvrossem
approved these changes
Nov 18, 2025
Contributor
vvrossem
left a comment
vvrossem
left a comment
There was a problem hiding this comment.
LGTM, I think you can squash [IMP] Update code to match with v19 with [19.0][MIG] mail_composer_cc_bcc: Migration to 19.0.
And while you are at it:
Consider to squash administrative commits (if any) with the previous commit for reducing commit noise. Check https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate for details.
Also, it could be the opportunity to update the .png files (if relevant)
imlopes
approved these changes
Nov 18, 2025
Contributor
|
This PR has the |
imlopes
force-pushed
the
19.0-mail_composer_cc_bcc
branch
2 times, most recently
from
c0cbcf5 to
60c3aa7
Compare
yankinmax
force-pushed
the
19.0-mail_composer_cc_bcc
branch
from
b2a4020 to
3877021
Compare
Contributor
|
@etobella Can you please merge? |
|
LGTM |
|
When merge? any ETA? thx |
StefanRijnhart
changed the title
Member
|
/ocabot migration mail_composer_cc_bcc |
| class IrMailServer(models.Model): | ||
| _inherit = "ir.mail_server" | ||
|
|
||
| def _prepare_email_message(self, message, smtp_session): |
Member
There was a problem hiding this comment.
Method was renamed: odoo/odoo@e147c778ebbd0#diff-e46e2629963b0ad64aed7a7b02f49caea5bfacd952b77abcb2954f2437c9222aL668-R646. This implies a missing test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.