Skip to content

[17.0][ADD] product_margin_report_sale_margin - #246

Open
edescalona wants to merge 1 commit into
OCA:17.0from
BinhexTeam:17.0-add-product_margin_report_sale_margin
Open

[17.0][ADD] product_margin_report_sale_margin#246
edescalona wants to merge 1 commit into
OCA:17.0from
BinhexTeam:17.0-add-product_margin_report_sale_margin

Conversation

@edescalona

@edescalona edescalona commented Jul 10, 2025

Copy link
Copy Markdown

@BinhexTeam

This new module allows you to add two new fields for the sales margin in the Product Margins report.

@edescalona
edescalona force-pushed the 17.0-add-product_margin_report_sale_margin branch from 0500fb1 to 64a5592 Compare July 10, 2025 16:51
christian-ramos-tecnativa
christian-ramos-tecnativa approved these changes Jul 10, 2025
View reviewed changes

@christian-ramos-tecnativa christian-ramos-tecnativa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I’d like to add more context to these two new fields. Currently, this report includes all sales and purchases in the range by default when calculating the values.
For example, if I’ve purchased 100 tables but only 10 have been sold so far, the margin will appear negative, which can be misleading. In this case, the report seems to reflect more of a cost vs. revenue view of the product rather than actual profitability.
Here’s a screenshot to illustrate the scenario:
image
This new values add a lot of value to this report.
Thanks

@github-actions

github-actions Bot commented Nov 9, 2025

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 9, 2025
rrebollo
rrebollo approved these changes Dec 11, 2025
View reviewed changes

@rrebollo rrebollo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review: Great work! The code looks good to me (LGTM). Thank you for your contribution! I've provided a few suggestions for your consideration—feel free to address them as you see fit.

Comment thread product_margin_report_sale_margin/readme/DESCRIPTION.md Outdated
adasatorres
adasatorres approved these changes Dec 12, 2025
View reviewed changes

@adasatorres adasatorres left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM!

@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 14, 2025
@edescalona

edescalona commented Dec 24, 2025

Copy link
Copy Markdown
Author

ping @legalsylvain

@github-actions

github-actions Bot commented Apr 26, 2026

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 26, 2026
@github-actions github-actions Bot closed this May 31, 2026
@jelenapoblet jelenapoblet reopened this Oct 9, 2026
@OCA-git-bot OCA-git-bot added series:17.0 mod:product_margin_report_sale_margin Module product_margin_report_sale_margin labels Oct 9, 2026
@edescalona
edescalona force-pushed the 17.0-add-product_margin_report_sale_margin branch from 64a5592 to a3e5d1e Compare October 9, 2026 14:55
@edescalona

edescalona commented Oct 9, 2026

Copy link
Copy Markdown
Author

Hi @jelenapoblet , could you try merging this PR?

@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 11, 2026
@edescalona

edescalona commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Hi @jelenapoblet @legalsylvain , could you try merging this PR? Thanks

jelenapoblet
jelenapoblet reviewed Oct 20, 2026
View reviewed changes
Comment thread product_margin_report_sale_margin/readme/USAGE.md Outdated
Comment thread product_margin_report_sale_margin/models/product_product.py
@OCA-git-bot

OCA-git-bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@edescalona
edescalona force-pushed the 17.0-add-product_margin_report_sale_margin branch from a3e5d1e to 8a2d61a Compare October 20, 2026 14:17
@edescalona

edescalona commented Oct 20, 2026

Copy link
Copy Markdown
Author

Hi @jelenapoblet thanks for your comments, could you please try again review?

@jelenapoblet

jelenapoblet commented Oct 20, 2026

Copy link
Copy Markdown

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-246-by-jelenapoblet-bump-nobump, awaiting test results.

@OCA-git-bot

OCA-git-bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

@jelenapoblet The merge process could not be finalized, because command twine upload --disable-progress-bar --non-interactive --repository-url https://upload.pypi.org/legacy/ -u __token__ odoo_addon_product_margin_report_sale_margin-17.0.1.0.0.2-py3-none-any.whl failed with output:

Uploading distributions to https://upload.pypi.org/legacy/
Uploading 
odoo_addon_product_margin_report_sale_margin-17.0.1.0.0.2-py3-none-any.whl
�[33mWARNING �[0m Error during upload. Retry with the --verbose option for more details. 
�[31mERROR   �[0m HTTPError: 429 Too Many Requests from https://upload.pypi.org/legacy/  
         Too Many Requests

@jelenapoblet

jelenapoblet commented Oct 20, 2026

Copy link
Copy Markdown

@OCA/pypi-support another one here. Thanks

@sebalix

sebalix commented Oct 23, 2026

Copy link
Copy Markdown

@jelenapoblet name reserved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jelenapoblet jelenapoblet jelenapoblet approved these changes
+3 more reviewers
@rrebollo rrebollo rrebollo approved these changes
@christian-ramos-tecnativa christian-ramos-tecnativa christian-ramos-tecnativa approved these changes
@adasatorres adasatorres adasatorres approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved mod:product_margin_report_sale_margin Module product_margin_report_sale_margin ready to merge series:17.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@edescalona @OCA-git-bot @jelenapoblet @sebalix @rrebollo @christian-ramos-tecnativa @adasatorres