[18.0][MIG] stock account operating unit: Migration to 18.0#769
Open
[18.0][MIG] stock account operating unit: Migration to 18.0#769
Conversation
Contributor
|
Hi @AtaponDew the dependency is merged now :) Can you please rebase? |
kongrattapong
suggested changes
Jun 11, 2025
Comment on lines
11
to
20
| def _generate_valuation_lines_data( | ||
| self, | ||
| partner_id, | ||
| qty, | ||
| debit_value, | ||
| credit_value, | ||
| debit_account_id, | ||
| credit_account_id, | ||
| description, | ||
| ): |
There was a problem hiding this comment.
you are missing parameter: svl_id
Suggested change
| def _generate_valuation_lines_data( | |
| self, | |
| partner_id, | |
| qty, | |
| debit_value, | |
| credit_value, | |
| debit_account_id, | |
| credit_account_id, | |
| description, | |
| ): | |
| def _generate_valuation_lines_data( | |
| self, | |
| partner_id, | |
| qty, | |
| debit_value, | |
| credit_value, | |
| debit_account_id, | |
| credit_account_id, | |
| svl_id, | |
| description, | |
| ): |
Author
There was a problem hiding this comment.
Thank you @kongrattapong, I have committed fix of this issue.
Added Test Cases. Improved code for test cases Migrated Valuation method of quants. Migrated Valuation method _account_entry_move of quants. Completed test cases and modified valuation method
Currently translated at 100.0% (3 of 3 strings) Translation: operating-unit-13.0/operating-unit-13.0-stock_account_operating_unit Translate-URL: https://translation.odoo-community.org/projects/operating-unit-13-0/operating-unit-13-0-stock_account_operating_unit/es/
FIX test-requirements
…it is not longer required
AtaponDew
force-pushed
the
18.0-mig-stock_account_operating_unit
branch
from
379c656 to
630d914
Compare
…e_valuation_lines_data
Author
|
@AaronHForgeFlow I've already rebase, please review. Thanks. |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
AaronHForgeFlow
removed
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.