[19.0][MIG] project_task_stage_auto_state#1717
Conversation
OCA-git-bot
added
series:19.0
mod:project_task_stage_auto_state
[UPD] Update project_task_stage_auto_state.pot [BOT] post-merge updates
Translated using Weblate (Italian) Currently translated at 100.0% (22 of 22 strings) Translation: project-18.0/project-18.0-project_task_stage_auto_state Translate-URL: https://translation.odoo-community.org/projects/project-18-0/project-18-0-project_task_stage_auto_state/it/
Shide
force-pushed
the
19.0-mig-project_task_stage_auto_state
branch
from
0d54c7e to
8f53f4b
Compare
EmilioPascual
left a comment
EmilioPascual
left a comment
There was a problem hiding this comment.
LGTM. Functional and code review
luisDIXMIT
left a comment
luisDIXMIT
left a comment
There was a problem hiding this comment.
Code review and tested on runboat, LGTM
chienandalu
left a comment
chienandalu
left a comment
There was a problem hiding this comment.
Non blocking:
Did you see the now record rotting feature in v19?
Do you think it'd make sense that auto_done/auto_cancel would revolve around it?
| <xpath expr="//sheet/group" position="inside"> | ||
| <group> | ||
| <group string="Auto-Done"> |
There was a problem hiding this comment.
The resulting layout is a little bit weird:
There was a problem hiding this comment.
It's a separate group with a lot of possibilities... :/
You don't need to visit this stages a lot, so I'll keep it as it is
There was a problem hiding this comment.
No, that's ok, what I meant is that they are weirdly aligned with the other group
| "external_dependencies": { | ||
| "python": ["freezegun"], | ||
| }, |
There was a problem hiding this comment.
It'd included in the core. You don't need to declare it in the manifest
I will take a deep look at it! But I think this module should be as it is. Maybe another module using the rot feature could be interesting. |
|
/ocabot migration project_task_stage_auto_state |
rafaelbn
left a comment
rafaelbn
left a comment
There was a problem hiding this comment.
Thank you!
/ocabot merge patch
|
What a great day to merge this nice PR. Let's do it! |
|
@rafaelbn your merge command was aborted due to failed check(s), which you can inspect on this commit of 19.0-ocabot-merge-pr-1717-by-rafaelbn-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
7 participants
Straight forward migration
MT-14700 @moduon @chienandalu @EmilioPascual @yajo please review if you want 😄