Skip to content

[17.0][IMP] hr_shift: add active to shift templates#34

Merged
OCA-git-bot merged 1 commit into
OCA:17.0from
TesseraOdoo:17.0-imp-hr_shift-shift_template_active
Apr 17, 2026
Merged

[17.0][IMP] hr_shift: add active to shift templates#34
OCA-git-bot merged 1 commit into
OCA:17.0from
TesseraOdoo:17.0-imp-hr_shift-shift_template_active

Conversation

@Abranes

@Abranes Abranes commented Apr 17, 2026

Copy link
Copy Markdown
Member

Add active field to hr.shift.template model to allow archive shifts that are no longer in use.

@pedrobaeza pedrobaeza added this to the 17.0 milestone Apr 17, 2026
pedrobaeza
pedrobaeza reviewed Apr 17, 2026
View reviewed changes
Comment thread hr_shift/views/shift_template_views.xml Outdated
@Abranes Abranes force-pushed the 17.0-imp-hr_shift-shift_template_active branch from 1bef8fc to 07b6853 Compare April 17, 2026 10:25
victoralmau
victoralmau approved these changes Apr 17, 2026
View reviewed changes

@victoralmau victoralmau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review OK

@pedrobaeza

pedrobaeza commented Apr 17, 2026

Copy link
Copy Markdown
Member

Before merging, do you think we should apply any restriction to archive if there's something related?

@Abranes

Abranes commented Apr 17, 2026

Copy link
Copy Markdown
Member Author

what kind of restriction you're thinking of? In our case, we need to archive the shifts because they won't be used anymore, but they have been used in the past

@pedrobaeza

pedrobaeza commented Apr 17, 2026

Copy link
Copy Markdown
Member

I'm thinking of not letting archive it if still in use, but not sure how to achieve that or if it makes sense.

@Abranes

Abranes commented Apr 17, 2026

Copy link
Copy Markdown
Member Author

I don't think it's necessary, because when we archive a shift that's still in use, the column in the kanban is still shown, you just can't select it for new allocations.

@pedrobaeza

pedrobaeza commented Apr 17, 2026

Copy link
Copy Markdown
Member

Ok then.

/ocabot merge minor

@OCA-git-bot

OCA-git-bot commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-34-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 666cc44 into OCA:17.0 Apr 17, 2026
7 checks passed
@OCA-git-bot

OCA-git-bot commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at a4458c6. Thanks a lot for contributing to OCA. ❤️

@Abranes Abranes deleted the 17.0-imp-hr_shift-shift_template_active branch April 17, 2026 14:53
@victoralmau victoralmau mentioned this pull request Apr 21, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

+1 more reviewer

@victoralmau victoralmau victoralmau approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 mod:hr_shift Module hr_shift series:17.0

Projects

None yet

Milestone

17.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Abranes @pedrobaeza @OCA-git-bot @victoralmau