Merged
Conversation
chrisknoll
reviewed
Mar 27, 2026
Collaborator
chrisknoll
left a comment
chrisknoll
left a comment
There was a problem hiding this comment.
Looks good, tho i think there's some open questions about the permissions such as: can you generate without needing read access to a cohort definition?
In any event, glad you found these typos and shocked I didn't catch them the first time around as I was testing the cohort generation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes minor adjustments to security annotations in the backend service code, primarily correcting permission checks in method-level security expressions.