fix(airflow): give the DAGs the object store connection - #71
Open
alex-mabrouk wants to merge 1 commit into
Open
Conversation
alex-mabrouk
force-pushed
the
fix/airflow-storage-connection
branch
from
August 29, 2026 11:35
620e15c to
40405b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
airflowpackage now gets its object store configuration from the project'sstorageConnection, just like the other data-service packages.It takes a
storageconnectionRefand ans3SecretRef, then passes the endpoint, region and S3 credentials to Airflow task pods throughextraEnv:AIRFLOW_ETL_S3_ENDPOINTAWS_REGIONstorageis also added to the package dependencies so the release waits for the object store to be ready.This follows the same approach on JupyterHub, where the hardcoded endpoint was replaced with
{{ storage.endpoints.apiUrl }}from the project'sstorageConnection.Package tag bumped to
3.2.1-p07.Related Issue
Fixes #70
Type of Change
How to Test
3.2.1-p07withstorageands3SecretRefconfigured, then check that the Airflow scheduler has the expected S3 environment variablesokdp-examplesand check that it writes to the object store configured by the project'sstorageConnection, rather than to the hardcoded endpoint.Checklist